Changeset 35530 in vbox

Timestamp:

Jan 13, 2011 2:38:51 PM (14 years ago)

Author:

vboxsync

Message:

RDP/client: fix memory allocation in USB device enumeration and add some sanity tests

File:

• trunk/src/VBox/RDP/client/vrdp/rdpusb.c (modified) (2 diffs)

trunk/src/VBox/RDP/client/vrdp/rdpusb.c

@@ -149 +149 @@
 unsigned countUSBDevices(PUSBDEVICE pDevices)
 {
-    unsigned i;
-    PUSBDEVICE pDevice;
-    for (i = 0, pDevice = pDevices; pDevices->pNext;
-         ++i, pDevices = pDevices->pNext);
+    unsigned i = 0;
+    for (; pDevices; pDevices = pDevices->pNext)
+        ++i;
     return i;
 }
@@ -226 +225 @@
 {
     char *pBuf;
-    unsigned cbBuf, iCurrent;
+    unsigned cDevs, cbBuf, iCurrent;
     uint16_t iNext;
     PUSBDEVICE pCurrent;
 
-    cbBuf = countUSBDevices(pDevices) * DEV_ENTRY_SIZE + 2;
+    cDevs = countUSBDevices(pDevices);
+    cbBuf = cDevs * DEV_ENTRY_SIZE + 2;
     pBuf = (char *)xmalloc(cbBuf);
     memset(pBuf, 0, cbBuf);
     for (pCurrent = pDevices, iCurrent = 0; pCurrent;
-         pCurrent = pCurrent->pNext, iCurrent += iNext)
+         pCurrent = pCurrent->pNext, iCurrent += iNext, --cDevs)
+    {
+        unsigned i, cZeros;
+
+        AssertReturnVoidStmt(iCurrent + DEV_ENTRY_SIZE + 2 <= cbBuf,
+                             free(pBuf));
         fillWireListEntry(pBuf + iCurrent, pCurrent, &iNext);
+            DevListEntry *pEntry = (DevListEntry *)(pBuf + iCurrent);
+        /* Sanity tests */
+        for (i = iCurrent + sizeof(DevListEntry), cZeros = 0;
+             i < iCurrent + iNext; ++i)
+             if (pBuf[i] == 0)
+                 ++cZeros;
+        AssertReturnVoidStmt(cZeros ==   RT_BOOL(pEntry->oManufacturer)
+                                       + RT_BOOL(pEntry->oProduct)
+                                       + RT_BOOL(pEntry->oSerialNumber),
+                             free(pBuf));
+        AssertReturnVoidStmt(   pEntry->oManufacturer == 0
+                             || pBuf[pEntry->oManufacturer] != '\0',
+                             free(pBuf));
+        AssertReturnVoidStmt(   pEntry->oProduct == 0
+                             || pBuf[pEntry->oProduct] != '\0',
+                             free(pBuf));
+        AssertReturnVoidStmt(   pEntry->oSerialNumber == 0
+                             || pBuf[pEntry->oSerialNumber] != '\0',
+                             free(pBuf));
+        AssertReturnVoidStmt(cZeros == 0 || pBuf[iCurrent + iNext - 1] == '\0',
+                             free(pBuf));
+    }
     *pLen = iCurrent + iNext + 2;
+    Assert(cDevs == 0);
+    Assert(*pLen <= cbBuf);
     return pBuf;
 }