Changeset 35534 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jan 13, 2011 3:01:40 PM (14 years ago)

Author:

vboxsync

Message:

VBoxManageGuestCtrl.cpp: Some u32TimeoutMS todos.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -505 +505 @@
                         || fWaitForStdErr)
                     {
+                        /** @todo r=bird: Why use u32TimeoutMS here?  */
                         rc = guest->GetProcessOutput(uPID, 0 /* aFlags */,
                                                      u32TimeoutMS, _64K, ComSafeArrayAsOutParam(aOutputData));
@@ -545 +546 @@
                             break;
 
+                        /** @todo r=bird: Why only apply the timeout here?
+                         *        Shouldn't it time out regardless of
+                         *        whether there is more output or not? */
                         if (   fTimeout
                             && RTTimeMilliTS() - u64StartMS > u32TimeoutMS + 5000)