Changeset 35541 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Jan 13, 2011 3:41:29 PM (14 years ago)

Author:

vboxsync

Message:

VBoxManage/GuestCtrl: Timeout adjustments.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (8 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -317 +317 @@
     bool fWaitForStdErr = false;
     bool fVerbose = false;
-    bool fTimeout = false;
 
     int vrc = VINF_SUCCESS;
@@ -374 +373 @@
             case 't': /* Timeout */
                 u32TimeoutMS = ValueUnion.u32;
-                fTimeout = true;
                 break;
 
@@ -461 +459 @@
             if (fWaitForExit)
             {
-                if (fTimeout)
+                if (u32TimeoutMS) /* Wait with a certain timeout. */
                 {
                     /* Calculate timeout value left after process has been started.  */
@@ -468 +466 @@
                     if (u32TimeoutMS > u64Elapsed)
                     {
-                        u32TimeoutMS -= (uint32_t)u64Elapsed;
                         if (fVerbose)
-                            RTPrintf("Waiting for process to exit (%ums left) ...\n", u32TimeoutMS);
+                            RTPrintf("Waiting for process to exit (%ums left) ...\n", u32TimeoutMS - u64Elapsed);
                     }
                     else
@@ -478 +475 @@
                     }
                 }
-                else if (fVerbose)
+                else if (fVerbose) /* Wait forever. */
                     RTPrintf("Waiting for process to exit ...\n");
 
@@ -505 +502 @@
                         || fWaitForStdErr)
                     {
-                        /** @todo r=bird: Why use u32TimeoutMS here?  */
                         rc = guest->GetProcessOutput(uPID, 0 /* aFlags */,
-                                                     u32TimeoutMS, _64K, ComSafeArrayAsOutParam(aOutputData));
+                                                     RT_MAX(0, u32TimeoutMS - (RTTimeMilliTS() - u64StartMS)) /* Timeout in ms */,
+                                                     _64K, ComSafeArrayAsOutParam(aOutputData));
                         if (FAILED(rc))
                         {
                             vrc = ctrlPrintError(guest, COM_IIDOF(IGuest));
-
                             cbOutputData = 0;
-                            fCompleted = true; /* rc contains a failure, so we'll go into aborted state down below. */
                         }
                         else
@@ -541 +536 @@
                         }
                     }
-                    if (cbOutputData <= 0) /* No more output data left? */
-                    {
-                        if (fCompleted)
-                            break;
-
-                        /** @todo r=bird: Why only apply the timeout here?
-                         *        Shouldn't it time out regardless of
-                         *        whether there is more output or not? */
-                        if (   fTimeout
-                            && RTTimeMilliTS() - u64StartMS > u32TimeoutMS + 5000)
-                        {
-                            progress->Cancel();
-                            break;
-                        }
-                    }
+
+                    /* No more output data left? Then wait a little while ... */
+                    if (cbOutputData <= 0)
+                        progress->WaitForCompletion(1 /* ms */);
 
                     /* Process async cancelation */
@@ -574 +558 @@
                     }
 
-                    /* Make sure the loop is not too tight. */
-                    RTThreadYield();
+                    /* Did we run out of time? */
+                    if (   u32TimeoutMS
+                        && RTTimeMilliTS() - u64StartMS > u32TimeoutMS)
+                    {
+                        progress->Cancel();
+                        break;
+                    }
                 }