Changeset 35587 in vbox

Timestamp:

Jan 17, 2011 2:21:04 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

69482

Message:

FE/Qt: New VM Wizard: Warn the user if the machine folder can not be created due to lack of permissions.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/VBoxProblemReporter.cpp (modified) (1 diff)
• globals/VBoxProblemReporter.h (modified) (1 diff)
• wizards/newvm/UINewVMWzd.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxProblemReporter.cpp

@@ -1972 +1972 @@
 }
 
+void VBoxProblemReporter::warnAboutCannotCreateMachineFolder(QWidget *pParent, const QString &strFolderName)
+{
+    message(pParent ? pParent : mainWindowShown(), Critical,
+            tr("<p>Cannot create the machine folder:</p>"
+               "<p><b>%1</b></p>"
+               "<p>Please check you have the permissions required to do so.</p>").arg(strFolderName));
+}
+
 /**
  *  @return @c true if the user has selected to continue without attaching a

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxProblemReporter.h

@@ -323 +323 @@
     bool confirmVMReset (QWidget *aParent);
 
+    void warnAboutCannotCreateMachineFolder(QWidget *pParent, const QString &strFolderName);
     bool confirmHardDisklessMachine (QWidget *aParent);
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UINewVMWzd.cpp

@@ -266 +266 @@
 {
     /* Cleanup old folder if present: */
-    cleanupMachineFolder();
+    bool fMachineFolderDeleted = cleanupMachineFolder();
+    if (!fMachineFolderDeleted)
+    {
+        vboxProblem().warnAboutCannotCreateMachineFolder(this, m_strMachineFolder);
+        return false;
+    }
+
     /* Get VBox: */
     CVirtualBox vbox = vboxGlobal().virtualBox();
@@ -276 +282 @@
     /* Get machine directory: */
     QString strMachineFolder = fileInfo.absolutePath();
+
     /* Try to create this machine directory (and it's predecessors): */
     bool fMachineFolderCreated = QDir().mkpath(strMachineFolder);
+    if (!fMachineFolderCreated)
+    {
+        vboxProblem().warnAboutCannotCreateMachineFolder(this, strMachineFolder);
+        return false;
+    }
+
     /* Initialize machine dir value: */
-    if (fMachineFolderCreated)
-        m_strMachineFolder = strMachineFolder;
-    /* Return creation result: */
-    return fMachineFolderCreated;
+    m_strMachineFolder = strMachineFolder;
+    return true;
 }
 
@@ -289 +300 @@
     /* Return if machine folder was NOT set: */
     if (m_strMachineFolder.isEmpty())
-        return false;
+        return true;
     /* Try to cleanup this machine directory (and it's predecessors): */
     bool fMachineFolderRemoved = QDir().rmpath(m_strMachineFolder);