Changeset 35790 in vbox

Timestamp:

Jan 31, 2011 3:35:27 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

69761

Message:

DisplayImpl: check input parameters in TakeScreenshot* methods.

File:

• trunk/src/VBox/Main/src-client/DisplayImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -2349 +2349 @@
     CheckComArgExpr(height, height != 0);
 
+    /* Do not allow too large screenshots. This also filters out negative
+     * values passed as either 'width' or 'height'.
+     */
+    CheckComArgExpr(width, width <= 32767);
+    CheckComArgExpr(height, height <= 32767);
+
     AutoCaller autoCaller(this);
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
@@ -2398 +2404 @@
     CheckComArgExpr(height, height != 0);
 
+    /* Do not allow too large screenshots. This also filters out negative
+     * values passed as either 'width' or 'height'.
+     */
+    CheckComArgExpr(width, width <= 32767);
+    CheckComArgExpr(height, height <= 32767);
+
     AutoCaller autoCaller(this);
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
@@ -2470 +2482 @@
     CheckComArgExpr(width, width != 0);
     CheckComArgExpr(height, height != 0);
+
+    /* Do not allow too large screenshots. This also filters out negative
+     * values passed as either 'width' or 'height'.
+     */
+    CheckComArgExpr(width, width <= 32767);
+    CheckComArgExpr(height, height <= 32767);
 
     AutoCaller autoCaller(this);