Changeset 35826 in vbox

Timestamp:

Feb 3, 2011 8:17:33 AM (14 years ago)

Author:

vboxsync

Message:

NAT/udp/socket: let's NAT send bodyless packets without annoying of memory management system.

File:

• trunk/src/VBox/Devices/Network/slirp/socket.c (modified) (2 diffs)

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -870 +870 @@
     struct sockaddr_in host_addr;
 #endif
-    caddr_t buf;
+    caddr_t buf = 0;
     int mlen;
 
@@ -921 +921 @@
 
     /* Don't care what port we get */
+    /*
+     * > nmap -sV -T4 -O -A -v -PU3483 255.255.255.255 
+     * generates bodyless messages, annoying memmory management system.
+     */
     mlen = m_length(m, NULL);
-    buf = RTMemAlloc(mlen);
-    if (buf == NULL)
-    {
-        return -1;
-    }
-    m_copydata(m, 0, mlen, buf);
+    if (mlen > 0)
+    {
+        buf = RTMemAlloc(mlen);
+        if (buf == NULL)
+        {
+            return -1;
+        }
+        m_copydata(m, 0, mlen, buf);
+    }
     ret = sendto(so->s, buf, mlen, 0,
                  (struct sockaddr *)&addr, sizeof (struct sockaddr));
-    RTMemFree(buf);
+    if (buf)
+        RTMemFree(buf);
     if (ret < 0)
     {