Changeset 35925 in vbox

Timestamp:

Feb 10, 2011 11:12:40 AM (14 years ago)

Author:

vboxsync

Message:

NAT: icmp_error frees mbuf at the end of processing.

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmp.c (modified) (3 diffs)

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -635 +635 @@
 
     memcpy(&icp->icmp_ip, msrc->m_data, s_ip_len);   /* report the ip packet */
-    m_freem(pData, msrc);
 
     HTONS(icp->icmp_ip.ip_len);
@@ -673 +672 @@
     icmpstat.icps_reflect++;
 
+    /* clear source datagramm in positive branch */
+    m_freem(pData, msrc);
     return;
 
@@ -679 +680 @@
 
 end_error:
+
+    /*
+     * clear source datagramm in case if some of requirement haven't been met.
+     */
+    if (!msrc)
+        m_freem(pData, msrc);
+
     {
         static bool fIcmpErrorReported;