Changeset 35994 in vbox

Timestamp:

Feb 16, 2011 1:30:53 PM (14 years ago)

Author:

vboxsync

Message:

Two cases where CPUM_CHANGED_GLOBAL_TLB_FLUSH was missing, causing stale TLB entries and mayhem.

Location:

trunk

Files:

• include/VBox/vmm/cpum.h (modified) (1 diff)
• src/recompiler/VBoxRecompiler.c (modified) (1 diff)

trunk/include/VBox/vmm/cpum.h

@@ -367 +367 @@
 #define CPUM_CHANGED_HIDDEN_SEL_REGS            RT_BIT(10)
 #define CPUM_CHANGED_CPUID                      RT_BIT(11)
-#define CPUM_CHANGED_ALL                        \
-    ( CPUM_CHANGED_FPU_REM | CPUM_CHANGED_CR0 | CPUM_CHANGED_CR3 | CPUM_CHANGED_CR4 | CPUM_CHANGED_GDTR | CPUM_CHANGED_IDTR \
-     | CPUM_CHANGED_LDTR | CPUM_CHANGED_TR | CPUM_CHANGED_SYSENTER_MSR | CPUM_CHANGED_HIDDEN_SEL_REGS | CPUM_CHANGED_CPUID )
+/** All except CPUM_CHANGED_HIDDEN_SEL_REGS_INVALID.  */
+#define CPUM_CHANGED_ALL                        (  CPUM_CHANGED_FPU_REM \
+                                                 | CPUM_CHANGED_CR0 \
+                                                 | CPUM_CHANGED_GLOBAL_TLB_FLUSH \
+                                                 | CPUM_CHANGED_CR3 \
+                                                 | CPUM_CHANGED_CR4 \
+                                                 | CPUM_CHANGED_GDTR \
+                                                 | CPUM_CHANGED_IDTR \
+                                                 | CPUM_CHANGED_LDTR \
+                                                 | CPUM_CHANGED_TR \
+                                                 | CPUM_CHANGED_SYSENTER_MSR \
+                                                 | CPUM_CHANGED_HIDDEN_SEL_REGS \
+                                                 | CPUM_CHANGED_CPUID )
 /** This one is used by raw-mode to indicate that the hidden register
  * information is not longer reliable and have to be re-determined.

trunk/src/recompiler/VBoxRecompiler.c

@@ -1934 +1934 @@
     fFlags = CPUMR3RemEnter(pVCpu, &uCpl);
     LogFlow(("CPUMR3RemEnter %x %x\n", fFlags, uCpl));
-    if (fFlags & (  CPUM_CHANGED_CR4  | CPUM_CHANGED_CR3  | CPUM_CHANGED_CR0
-                  | CPUM_CHANGED_GDTR | CPUM_CHANGED_IDTR | CPUM_CHANGED_LDTR
-                  | CPUM_CHANGED_FPU_REM | CPUM_CHANGED_SYSENTER_MSR | CPUM_CHANGED_CPUID))
+    if (fFlags & (  CPUM_CHANGED_GLOBAL_TLB_FLUSH
+                  | CPUM_CHANGED_CR4
+                  | CPUM_CHANGED_CR0
+                  | CPUM_CHANGED_CR3
+                  | CPUM_CHANGED_GDTR
+                  | CPUM_CHANGED_IDTR
+                  | CPUM_CHANGED_SYSENTER_MSR
+                  | CPUM_CHANGED_LDTR
+                  | CPUM_CHANGED_CPUID
+                  | CPUM_CHANGED_FPU_REM
+                 )
+        )
     {
         if (fFlags & CPUM_CHANGED_GLOBAL_TLB_FLUSH)