Changeset 36133 in vbox

Timestamp:

Mar 2, 2011 10:18:04 PM (14 years ago)

Author:

vboxsync

Message:

iSCSI: Clear tail pointer of waiting PDUs during reattach too (safety) and insert responses to NOP-in requests at the front of the waiting PDUs to transmit

File:

• trunk/src/VBox/Storage/ISCSI.cpp (modified) (4 diffs)

trunk/src/VBox/Storage/ISCSI.cpp

@@ -2219 +2219 @@
     if (!fFront)
     {
-        /* Link the PDU at the tail of the list. */
+        /* Insert PDU at the tail of the list. */
         if (!pImage->pIScsiPDUTxHead)
             pImage->pIScsiPDUTxHead = pIScsiPDUTx;
@@ -2228 +2228 @@
     else
     {
-        /* Link PDU to at the front of the list. */
+        /* Insert PDU at the beginning of the list. */
         pIScsiPDUTx->pNext = pImage->pIScsiPDUTxHead;
         pImage->pIScsiPDUTxHead = pIScsiPDUTx;
@@ -2484 +2484 @@
                     RTSgBufInit(&pIScsiPDUTx->SgBuf, pIScsiPDUTx->aISCSIReq, cnISCSIReq);
 
-                    /* Link the PDU to the list. */
-                    iscsiPDUTxAdd(pImage, pIScsiPDUTx, false /* fFront */);
+                    /*
+                     * Link the PDU to the list.
+                     * Insert at the front of the list to send the response as soon as possible
+                     * to avoid frequent reconnects for a slow connection when there are many PDUs
+                     * waiting.
+                     */
+                    iscsiPDUTxAdd(pImage, pIScsiPDUTx, true /* fFront */);
 
                     /* Start transfer of a PDU if there is no one active at the moment. */
@@ -3219 +3224 @@
         RTMemFree(pIScsiPDUTx);
     }
+
+    /* Clear the tail pointer (safety precaution). */
+    pImage->pIScsiPDUTxTail = NULL;
 
     /* Clear the current PDU too. */