Changeset 3617 in kBuild for trunk

Timestamp:

Oct 21, 2024 8:43:04 PM (6 months ago)

Author:

bird

Message:

kmk/winchildren.c: Use GetLogicalProcessorInformationEx/RelationGroup to get the group affinity masks and use these in calls to SetThreadGroupAffinity when we have them.

File:

• trunk/src/kmk/w32/winchildren.c (modified) (5 diffs)

trunk/src/kmk/w32/winchildren.c

@@ -345 +345 @@
 /** Array detailing how many active processors there are in each group. */
 static unsigned const      *g_pacProcessorsInGroup = &g_cProcessorGroups;
+/** Info from the GetLogicalProcessorInformationEx call - can be NULL. */
+static GROUP_RELATIONSHIP const *g_pGroupInfo = NULL;
+
 /** Kernel32!GetActiveProcessorGroupCount */
 static WORD (WINAPI        *g_pfnGetActiveProcessorGroupCount)(VOID);
 /** Kernel32!GetActiveProcessorCount */
 static DWORD (WINAPI       *g_pfnGetActiveProcessorCount)(WORD);
+/** Kernel32!GetLogicalProcessorInformationEx */
+static DWORD (WINAPI       *g_pfnGetLogicalProcessorInformationEx)(LOGICAL_PROCESSOR_RELATIONSHIP,
+                                                                   PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX, PDWORD);
 /** Kernel32!SetThreadGroupAffinity */
 static BOOL (WINAPI        *g_pfnSetThreadGroupAffinity)(HANDLE, CONST GROUP_AFFINITY *, GROUP_AFFINITY *);
@@ -460 +466 @@
     {
         hmod = GetModuleHandleA("KERNEL32.DLL");
-        *(FARPROC *)&g_pfnGetActiveProcessorGroupCount = GetProcAddress(hmod, "GetActiveProcessorGroupCount");
-        *(FARPROC *)&g_pfnGetActiveProcessorCount      = GetProcAddress(hmod, "GetActiveProcessorCount");
-        *(FARPROC *)&g_pfnSetThreadGroupAffinity       = GetProcAddress(hmod, "SetThreadGroupAffinity");
+        *(FARPROC *)&g_pfnGetActiveProcessorGroupCount     = GetProcAddress(hmod, "GetActiveProcessorGroupCount");
+        *(FARPROC *)&g_pfnGetActiveProcessorCount          = GetProcAddress(hmod, "GetActiveProcessorCount");
+        *(FARPROC *)&g_pfnSetThreadGroupAffinity           = GetProcAddress(hmod, "SetThreadGroupAffinity");
+        *(FARPROC *)&g_pfnGetLogicalProcessorInformationEx = GetProcAddress(hmod, "GetLogicalProcessorInformationEx");
+        /*(FARPROC *)&g_pfnGetSystemCpuSetInformation       = GetProcAddress(hmod, "GetSystemCpuSetInformation"); / * W10 */
+        /*(FARPROC *)&g_pfnSetThreadSelectedCpuSetMasks     = GetProcAddress(hmod, "SetThreadSelectedCpuSetMasks"); / * W11 */
         if (   g_pfnSetThreadGroupAffinity
             && g_pfnGetActiveProcessorCount
-            && g_pfnGetActiveProcessorGroupCount)
+            && g_pfnGetActiveProcessorGroupCount
+            && g_pfnGetLogicalProcessorInformationEx)
         {
             unsigned int *pacProcessorsInGroup;
@@ -478 +488 @@
                 pacProcessorsInGroup[iGroup] = g_pfnGetActiveProcessorCount(iGroup);
 
+            /* Get active process group affinity masks so we can set them correctly. */
+            {
+                DWORD cbNeeded = cbNeeded = offsetof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX, Group)
+                               + offsetof(GROUP_RELATIONSHIP, GroupInfo)
+                               + sizeof(PROCESSOR_GROUP_INFO) * (g_cProcessorGroups + 4);
+                PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX pInfo = (PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX)xcalloc(cbNeeded);
+                BOOL fRet = g_pfnGetLogicalProcessorInformationEx(RelationGroup, pInfo, &cbNeeded);
+                if (!fRet && GetLastError() == ERROR_BUFFER_OVERFLOW)
+                {
+                    free(pInfo);
+                    pInfo = (PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX)xcalloc(cbNeeded);
+                    fRet = g_pfnGetLogicalProcessorInformationEx(RelationGroup, pInfo, &cbNeeded);
+                }
+                if (   fRet
+                    && pInfo->Group.ActiveGroupCount > 0
+                    && pInfo->Group.ActiveGroupCount <= pInfo->Group.MaximumGroupCount)
+                {
+                    g_pGroupInfo = &pInfo->Group; /* leaked */
+                    pInfo = NULL;
+                }
+                else
+                    free(pInfo);
+            }
+
             MkWinChildInitCpuGroupAllocator(&g_ProcessorGroupAllocator);
         }
         else
         {
-            g_pfnSetThreadGroupAffinity       = NULL;
-            g_pfnGetActiveProcessorCount      = NULL;
-            g_pfnGetActiveProcessorGroupCount = NULL;
+            g_pfnSetThreadGroupAffinity           = NULL;
+            g_pfnGetActiveProcessorCount          = NULL;
+            g_pfnGetActiveProcessorGroupCount     = NULL;
+            g_pfnGetLogicalProcessorInformationEx = NULL;
         }
     }
@@ -1343 +1378 @@
         if (g_cProcessorGroups > 1)
         {
-            GROUP_AFFINITY Affinity = { 0 /* == all active apparently */, pWorker->iProcessorGroup, { 0, 0, 0 } };
+            GROUP_AFFINITY Affinity = { 0, pWorker->iProcessorGroup, { 0, 0, 0 } };
+            if (g_pGroupInfo && pWorker->iProcessorGroup < g_pGroupInfo->ActiveGroupCount)
+                Affinity.Mask = g_pGroupInfo->GroupInfo[pWorker->iProcessorGroup].ActiveProcessorMask;
             fRet = g_pfnSetThreadGroupAffinity(ProcInfo.hThread, &Affinity, NULL);
             assert(fRet);
@@ -2561 +2598 @@
     if (g_cProcessorGroups > 1)
     {
-        GROUP_AFFINITY Affinity = { 0 /* == all active apparently */, pWorker->iProcessorGroup, { 0, 0, 0 } };
-        BOOL fRet = g_pfnSetThreadGroupAffinity(GetCurrentThread(), &Affinity, NULL);
+        BOOL           fRet;
+        GROUP_AFFINITY Affinity = { 0, pWorker->iProcessorGroup, { 0, 0, 0 } };
+        if (g_pGroupInfo && pWorker->iProcessorGroup < g_pGroupInfo->ActiveGroupCount)
+            Affinity.Mask = g_pGroupInfo->GroupInfo[pWorker->iProcessorGroup].ActiveProcessorMask;
+
+        fRet = g_pfnSetThreadGroupAffinity(GetCurrentThread(), &Affinity, NULL);
         assert(fRet); (void)fRet;
 # ifndef NDEBUG