Changeset 36214 in vbox

Timestamp:

Mar 8, 2011 6:33:38 PM (14 years ago)

Author:

vboxsync

Message:

GuestProps: r=bird: Another Q for Michael.

Location:

trunk

Files:

• include/VBox/HostServices/GuestPropertySvc.h (modified) (2 diffs)
• src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp (modified) (2 diffs)

trunk/include/VBox/HostServices/GuestPropertySvc.h

@@ -115 +115 @@
  * RDONLYGUEST, RDONLYHOST and RDONLY
  */
+/** @todo r=bird: Michael, where to do enforce the "only every return one of
+ *        R*"? I cannot see it? */
+/** @todo r=bird: Should TRANSIENT_RESET imply TRANSIENT or not? See
+ *        VBoxServicePropCache.cpp.  You've introduced (or maybe just made an
+ *        existing one more obvious - see abouve) a buffer overrun in
+ *        writeFlags now. */
 enum { MAX_FLAGS_LEN =   sizeof("TRANSIENT_RESET, RDONLYGUEST") };
 
@@ -152 +158 @@
             unsigned i = 0;
             for (; i < RT_ELEMENTS(s_aFlagList); ++i)
-            {
                 if (RTStrNICmp(pcszNext, flagName(s_aFlagList[i]),
                                flagNameLen(s_aFlagList[i])) == 0)
                     break;
-            }
             if (RT_ELEMENTS(s_aFlagList) == i)
                 rc = VERR_PARSE_ERROR;

trunk/src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp

@@ -107 +107 @@
                  * guest property using the TRANSIENT and TRANSIENT_RESET flags.
                  */
+                /** @todo r=bird: TRANSIENT_RESET should imply TRANSIENT. See
+                 *        MAX_FLAGS_LEN... */
                 rc = VbglR3GuestPropWrite(u32ClientId, pszName, pszValue, "TRANSIENT,TRANSIENT_RESET");
                 if (rc == VERR_PARSE_ERROR)
@@ -113 +115 @@
                      * use the "TRANSIENT" flag -- better than nothing :-). */
                     rc = VbglR3GuestPropWrite(u32ClientId, pszName, pszValue, "TRANSIENT");
+                    /** @todo r=bird: Remember that the host doesn't support
+                     * this. */
                 }
             }