Changeset 36987 in vbox

Timestamp:

May 6, 2011 3:33:36 PM (14 years ago)

Author:

vboxsync

Message:

VBoxManage/GuestCtrl: Also create empty directories by default, comments.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -69 +69 @@
 static volatile bool    g_fGuestCtrlCanceled = false;
 
+/**
+ * An entry for a source element, including an optional filter.
+ */
 typedef struct SOURCEFILEENTRY
 {
@@ -96 +99 @@
 typedef std::vector<SOURCEFILEENTRY> SOURCEVEC, *PSOURCEVEC;
 
+/**
+ * An entry for an element which needs to be copied to the guest.
+ */
 typedef struct DESTFILEENTRY
 {
@@ -101 +107 @@
     Utf8Str mFileName;
 } DESTFILEENTRY, *PDESTFILEENTRY;
+/*
+ * Map for holding destination entires, whereas the key is the destination
+ * directory and the mapped value is a vector holding all elements for this directoy.
+ */
 typedef std::map< Utf8Str, std::vector<DESTFILEENTRY> > DESTDIRMAP, *PDESTDIRMAP;
 typedef std::map< Utf8Str, std::vector<DESTFILEENTRY> >::iterator DESTDIRMAPITER, *PDESTDIRMAPITER;
@@ -990 +1000 @@
             rc = VERR_NO_MEMORY;
     }
-    /* @todo Skip creating empty directories (or directories where a file filter (e.g. *.dll)
-     * did not find any files to copy. Make this configurable later! */
-    else if (itDest->second.size())
+    else /* Create sub-directories, also empty ones. */
     {
         if (!RTStrAPrintf(&pszDestFinal, "%s/%s", pszDestRoot, itDest->first.c_str()))