Changeset 37354 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

Jun 7, 2011 3:05:32 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

72121

Message:

PGM: Fixed locking issues in PGMR3PhysMMIORegister and PGMR3PhysMMIODeregister. Also addressed a harmless on in PGMR3PhysRomRegister (only used at init time, so no races). Fortified the code with assertions more lock assertion, replacing the incorrect PGMIsLocked() checks (we only care if the current thread is the lock owner). Cleaned up some ReturnStmt macros and adding more of them.

File:

• trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp

@@ -2481 +2481 @@
                          */
                         vrc = RTPathJoin(szDir, sizeof(szDir), m->strBaseDir.c_str(), Entry.szName); /* not really necessary */
-                        AssertLogRelRCReturnStmt(vrc, E_UNEXPECTED, RTDirClose(pDir));
+                        AssertLogRelRCReturnStmt(vrc, RTDirClose(pDir), E_UNEXPECTED);
                         a_pszName = Entry.szName;
                         fExists   = true;