Changeset 37389 in vbox for trunk/src/VBox/VMM

Timestamp:

Jun 8, 2011 4:13:49 PM (14 years ago)

Author:

vboxsync

Message:

HWACCMAll.cpp: Added todo for optimziating the poking a little bit.

File:

• trunk/src/VBox/VMM/VMMAll/HWACCMAll.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/HWACCMAll.cpp

@@ -134 +134 @@
             STAM_PROFILE_ADV_START(&pVCpu->hwaccm.s.StatSpinPokeFailed, z);
 
+/** @todo If more than one CPU is going to be poked, we could optimize this
+ *        operation by poking them first and wait afterwards.  Would require
+ *        recording who to poke and their current cWorldSwitchExits values,
+ *        that's something not suitable for stack... So, pVCpu->hm.s.something
+ *        then. */
         /* Spin until the VCPU has switched back (poking is async). */
         while (   ASMAtomicUoReadBool(&pVCpu->hwaccm.s.fCheckedTLBFlush)
@@ -167 +172 @@
         RTCPUID idHostCpu = pVCpu->hwaccm.s.idEnteredCpu;
         if (idHostCpu != NIL_RTCPUID)
-        {
             hmR0PokeCpu(pVCpu, idHostCpu);
-        }
 #else
         VMR3NotifyCpuFFU(pVCpu->pUVCpu, VMNOTIFYFF_FLAGS_POKE);