Changeset 37475 in vbox for trunk/include/VBox

Timestamp:

Jun 15, 2011 4:42:55 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

72291

Message:

DevAPIC: Locking reworking in progress.

File:

• trunk/include/VBox/vmm/pdmdev.h (modified) (3 diffs)

trunk/include/VBox/vmm/pdmdev.h

@@ -1074 +1074 @@
 
     /**
-     * Write MSR in APIC range.
+     * Write to a MSR in APIC range.
      *
      * @returns VBox status code.
      * @param   pDevIns         Device instance of the APIC.
      * @param   idCpu           Target CPU.
-     * @param   u32Reg          MSR to write.
-     * @param   u64Value        Value to write.
+     * @param   u32Reg          The MSR begin written to.
+     * @param   u64Value        The value to write.
+     *
+     * @remarks Unlike the other callbacks, the PDM lock is not taken before
+     *          calling this method.
      */
     DECLR3CALLBACKMEMBER(int, pfnWriteMSRR3, (PPDMDEVINS pDevIns, VMCPUID idCpu, uint32_t u32Reg, uint64_t u64Value));
 
     /**
-     * Read MSR in APIC range.
+     * Read from a MSR in APIC range.
      *
      * @returns VBox status code.
@@ -1091 +1094 @@
      * @param   idCpu           Target CPU.
      * @param   u32Reg          MSR to read.
-     * @param   pu64Value       Value read.
+     * @param   pu64Value       Where to return the read value.
      */
     DECLR3CALLBACKMEMBER(int, pfnReadMSRR3, (PPDMDEVINS pDevIns, VMCPUID idCpu, uint32_t u32Reg, uint64_t *pu64Value));
@@ -1098 +1101 @@
      * Private interface between the IOAPIC and APIC.
      *
-     * This is a low-level, APIC/IOAPIC implementation specific interface
-     * which is registered with PDM only because it makes life so much
-     * simpler right now (GC bits). This is a bad bad hack! The correct
-     * way of doing this would involve some way of querying GC interfaces
-     * and relocating them. Perhaps doing some kind of device init in GC...
+     * This is a low-level, APIC/IOAPIC implementation specific interface which
+     * is registered with PDM only because it makes life so much simpler right
+     * now (GC bits).  This is a bad bad hack!  The correct way of doing this
+     * would involve some way of querying GC interfaces and relocating them.
+     * Perhaps doing some kind of device init in GC...
      *
      * @returns status code.