Changeset 37505 in vbox

Timestamp:

Jun 16, 2011 4:37:47 PM (14 years ago)

Author:

vboxsync

Message:

hpetTimerRegWrite32 optimization

File:

• trunk/src/VBox/Devices/PC/DevHPET.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DevHPET.cpp

@@ -526 +526 @@
     HpetTimer *pHpetTimer = &pThis->aTimers[iTimerNo];
 
-    /** @todo iOldValue is only used by in HPET_TN_CFG, so this is a waste of
-     *   time. */
-    uint32_t u32Temp;
-    int rc = hpetTimerRegRead32(pThis, iTimerNo, iTimerReg, &u32Temp);
-    if (RT_FAILURE(rc))
-        return rc;
-    uint64_t iOldValue = u32Temp;
-
     switch (iTimerReg)
     {
@@ -539 +531 @@
         {
             Log(("write HPET_TN_CFG: %d: %x\n", iTimerNo, u32NewValue));
+            uint64_t const iOldValue = (uint32_t)pHpetTimer->u64Config;
 
             uint64_t u64Mask = HPET_TN_CFG_WRITE_MASK;