Changeset 3767 in vbox for trunk/src

Timestamp:

Jul 22, 2007 10:54:01 PM (18 years ago)

Author:

vboxsync

Message:

Reduce occurrences of the message "Spurios NAK on isa0060/serio0" from Linux guests. Only send 0xFE if we really want to release any pressed modifier, not on every focus release. The real fix is to find a better way to prevent guests to interprete the KEYPRESS/KEYRELEASE event of a modifier key in that situation.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp

@@ -2642 +2642 @@
     AssertMsg (attached, ("Console must be attached"));
 
-    LONG codes [2];
     CKeyboard keyboard = cconsole.GetKeyboard();
+    bool fSentRESEND = false;
 
     // send a dummy scan code (RESEND) to prevent the guest OS from recognizing
@@ -2650 +2650 @@
     // Note, that it's just a guess that sending RESEND will give the desired
     // effect :), but at least it works with NT and W2k guests.
-    /** @todo This seems to causes linux guests (in console mode) to cough a bit.
-     * We need to check if this is the cause of #1944 and/or #1949. --bird */
-    codes [0] = 0xFE;
-    keyboard.PutScancodes (codes, 1);
-
+
+    // @TODO Sending 0xFE is responsible for the warning 
+    //
+    //         ``atkbd.c: Spurious NAK on isa0060/serio0. Some program might
+    //           be trying access hardware directly''
+    //
+    //       on Linux guests (#1944). It might also be responsible for #1949. Don't
+    //       send this command unless we really have to release any key modifier.
+    //                                                                    --frank
     for (uint i = 0; i < SIZEOF_ARRAY (keys_pressed); i++)
     {
         if (keys_pressed [i] & IsKeyPressed)
         {
+            if (!fSentRESEND)
+            {
+                keyboard.PutScancode (0xFE);
+                fSentRESEND = true;
+            }
             keyboard.PutScancode (i | 0x80);
         }
         else if (keys_pressed [i] & IsExtKeyPressed)
         {
+            if (!fSentRESEND)
+            {
+                keyboard.PutScancode (0xFE);
+                fSentRESEND = true;
+            }
+            LONG codes [2];
             codes[0] = 0xE0;
             codes[1] = i | 0x80;