Changeset 37713 in vbox for trunk/src

Timestamp:

Jun 30, 2011 3:14:13 PM (13 years ago)

Author:

vboxsync

Message:

Main/linux/Performance: if collecting the stats for a process fails keep going, otherwise many stats updates are missing

File:

• trunk/src/VBox/Main/src-server/linux/PerformanceLinux.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/linux/PerformanceLinux.cpp

@@ -7 +7 @@
 
 /*
- * Copyright (C) 2008 Oracle Corporation
+ * Copyright (C) 2008-2011 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -75 +75 @@
         VMProcessStats vmStats;
         int rc = getRawProcessStats(*it, &vmStats.cpuUser, &vmStats.cpuKernel, &vmStats.pagesUsed);
-        if (RT_FAILURE(rc))
-            return rc;
-        mProcessStats[*it] = vmStats;
+        /* On failure, do NOT stop. Just skip the entry. Having the stats for
+         * one (probably broken) process frozen/zero is a minor issue compared
+         * to not updating many process stats and the host cpu stats. */
+        if (RT_SUCCESS(rc))
+            mProcessStats[*it] = vmStats;
     }
     if (hints.isHostCpuLoadCollected() || mProcessStats.size())