Changeset 37986 in vbox for trunk/src

Timestamp:

Jul 15, 2011 3:14:35 PM (13 years ago)

Author:

vboxsync

Message:

Wddm/3d: fix thread sync issues

Location:

trunk/src/VBox

Files:

• Additions/common/crOpenGL/context.c (modified) (3 diffs)
• Additions/common/crOpenGL/glx.c (modified) (3 diffs)
• Additions/common/crOpenGL/icd_drv.c (modified) (1 diff)
• Additions/common/crOpenGL/pack/packspu_misc.c (modified) (3 diffs)
• Additions/common/crOpenGL/stub.c (modified) (2 diffs)
• GuestHost/OpenGL/include/cr_hash.h (modified) (1 diff)
• GuestHost/OpenGL/util/hash.c (modified) (1 diff)

trunk/src/VBox/Additions/common/crOpenGL/context.c

@@ -497 +497 @@
 
 void
-stubGetWindowGeometry( const WindowInfo *window, int *x, int *y,
-                                             unsigned int *w, unsigned int *h )
+stubGetWindowGeometry(const WindowInfo *window, int *x, int *y,
+                      unsigned int *w, unsigned int *h )
 {
     RECT rect;
@@ -1133 +1133 @@
         return;
     }
+
+    crHashtableLock(stub.contextTable);
+
     context = (ContextInfo *) crHashtableSearch(stub.contextTable, contextId);
 
@@ -1167 +1170 @@
     crMemZero(context, sizeof(ContextInfo));  /* just to be safe */
     crHashtableDelete(stub.contextTable, contextId, crFree);
-}
-
+
+    crHashtableUnlock(stub.contextTable);
+}
 
 void

trunk/src/VBox/Additions/common/crOpenGL/glx.c

@@ -682 +682 @@
     }
 
-    if (ctx && drawable) {
+    if (ctx && drawable)
+    {
+        crHashtableLock(stub.windowTable);
+        crHashtableLock(stub.contextTable);
+
         context = (ContextInfo *) crHashtableSearch(stub.contextTable, (unsigned long) ctx);
         window = stubGetWindowInfo(dpy, drawable);
@@ -692 +696 @@
         }
     }
-    else {
+    else
+    {
         dpy = NULL;
         window = NULL;
@@ -702 +707 @@
 
     retVal = stubMakeCurrent(window, context);
+
+    if (ctx && drawable)
+    {
+        crHashtableUnlock(stub.contextTable);
+        crHashtableUnlock(stub.windowTable);
+    }
+
     return retVal;
 }

trunk/src/VBox/Additions/common/crOpenGL/icd_drv.c

@@ -95 +95 @@
     ContextInfo *context;
     WindowInfo *window;
+    BOOL ret;
 
     /*crDebug( "DrvSetContext called(0x%x, 0x%x)", hdc, hglrc );*/
     (void) (callback);
 
+    crHashtableLock(stub.windowTable);
+    crHashtableLock(stub.contextTable);
+
     context = (ContextInfo *) crHashtableSearch(stub.contextTable, (unsigned long) hglrc);
     window = stubGetWindowInfo(hdc);
 
-    if (stubMakeCurrent( window, context )) {
-        return &icdTable;
-    }
-    else {
-        return NULL;
-    }
+    ret = stubMakeCurrent(window, context);
+
+    crHashtableUnlock(stub.contextTable);
+    crHashtableUnlock(stub.windowTable);
+
+    return ret ? &icdTable:NULL;
 }
 

trunk/src/VBox/Additions/common/crOpenGL/pack/packspu_misc.c

@@ -104 +104 @@
 }
 
+#define PACK_FORCED_SYNC
+
 void PACKSPU_APIENTRY packspu_Flush( void )
 {
     GET_THREAD(thread);
     int writeback = 1;
+    int found=0;
 
     if (!thread->bInjectThread)
@@ -126 +129 @@
         crLockMutex(&_PackMutex);
 
-        /*Make sure we process commands in order they should appear, so flush thread being injected first*/
+        /*Make sure we process commands in order they should appear, so flush other threads first*/
         for (i=0; i<MAX_THREADS; ++i)
         {
             if (pack_spu.thread[i].inUse
                 && (thread != &pack_spu.thread[i]) && pack_spu.thread[i].netServer.conn
-                && (pack_spu.thread[i].netServer.conn->u32ClientID == thread->netServer.conn->u32InjectClientID)
                 && pack_spu.thread[i].packer && pack_spu.thread[i].packer->currentBuffer)
             {
+#ifdef PACK_FORCED_SYNC
+                CRPackContext *pc = pack_spu.thread[i].packer;
+                unsigned char *data_ptr;
+
+                CR_GET_BUFFERED_POINTER( pc, 16 );
+                WRITE_DATA( 0, GLint, 16 );
+                WRITE_DATA( 4, GLenum, CR_WRITEBACK_EXTEND_OPCODE );
+                WRITE_NETWORK_POINTER( 8, (void *) &writeback );
+                WRITE_OPCODE( pc, CR_EXTEND_OPCODE );
+                CR_UNLOCK_PACKER_CONTEXT(pc);
+#endif
                 packspuFlush((void *) &pack_spu.thread[i]);
-                break;
+
+                if (pack_spu.thread[i].netServer.conn->u32ClientID == thread->netServer.conn->u32InjectClientID)
+                {
+                    found=1;
+                }
+
+#ifdef PACK_FORCED_SYNC
+                while (writeback)
+                    crNetRecv();
+#endif
             }
         }
 
-        if (i>=MAX_THREADS)
+        if (!found)
         {
             /*Thread we're supposed to inject commands for has been detached,
@@ -147 +169 @@
         }
 
+#ifdef PACK_FORCED_SYNC
+        writeback = 1;
+        crPackWriteback(&writeback);
+#endif
+        packspuFlush((void *) thread);
+
+#ifdef PACK_FORCED_SYNC
+        while (writeback)
+            crNetRecv();
+#endif
         crUnlockMutex(&_PackMutex);
-
-        packspuFlush((void *) thread);
     }
 }

trunk/src/VBox/Additions/common/crOpenGL/stub.c

@@ -127 +127 @@
     if (winInfo && winInfo->type == CHROMIUM && stub.spu)
     {
+        crHashtableLock(stub.windowTable);
+
         stub.spu->dispatch_table.WindowDestroy( winInfo->spuWindow );
-#ifdef CR_NEWWINTRACK
-        crLockMutex(&stub.mutex);
-#endif
+
 #ifdef WINDOWS
         if (winInfo->hVisibleRegion != INVALID_HANDLE_VALUE)
@@ -147 +147 @@
         }
 # endif
-#endif
-#ifdef CR_NEWWINTRACK
-        crUnlockMutex(&stub.mutex);
 #endif
         crForcedFlush();
         crHashtableDelete(stub.windowTable, window, crFree);
+
+        crHashtableUnlock(stub.windowTable);
     }
 }

trunk/src/VBox/GuestHost/OpenGL/include/cr_hash.h

@@ -36 +36 @@
 /*Returns GL_TRUE if given hashtable hold the data, pKey is updated with key value for data in this case*/
 DECLEXPORT(GLboolean) crHashtableGetDataKey(CRHashTable *pHash, void *pData, unsigned long *pKey);
+DECLEXPORT(void) crHashtableLock(CRHashTable *h);
+DECLEXPORT(void) crHashtableUnlock(CRHashTable *h);
 
 #ifdef __cplusplus

trunk/src/VBox/GuestHost/OpenGL/util/hash.c

@@ -353 +353 @@
 }
 
+void crHashtableLock(CRHashTable *h)
+{
+#ifdef CHROMIUM_THREADSAFE
+    crLockMutex(&h->mutex);
+#endif
+}
+
+void crHashtableUnlock(CRHashTable *h)
+{
+#ifdef CHROMIUM_THREADSAFE
+    crUnlockMutex(&h->mutex);
+#endif
+}
 
 void crHashtableWalk( CRHashTable *hash, CRHashtableWalkCallback walkFunc , void *dataPtr2)