Changeset 38041 in vbox for trunk/src/VBox

Timestamp:

Jul 18, 2011 9:01:18 PM (13 years ago)

Author:

vboxsync

Message:

Main/MachineImpl: fix automatic diff creation when cloning a VM (linked clone and full clone case)

File:

• trunk/src/VBox/Main/src-server/MachineImplCloneVM.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/MachineImplCloneVM.cpp

@@ -642 +642 @@
                     if (pLMedium.isNull())
                         throw E_POINTER;
-                    if (pLMedium->isReadOnly())
+                    ComObjPtr<Medium> pBase = pLMedium->getBase();
+                    if (pBase->isReadOnly())
                     {
                         ComObjPtr<Medium> pDiff;
@@ -799 +800 @@
             if (mtc.fCreateDiffs)
             {
-                if (pNewParent->isReadOnly())
+                const MEDIUMTASK &mt = mtc.chain.first();
+                ComPtr<IMedium> pMedium = mt.pMedium;
+                IMedium *pTmp = pMedium;
+                ComObjPtr<Medium> pLMedium = static_cast<Medium*>(pTmp);
+                if (pLMedium.isNull())
+                    throw E_POINTER;
+                ComObjPtr<Medium> pBase = pLMedium->getBase();
+                if (pBase->isReadOnly())
                 {
                     ComObjPtr<Medium> pDiff;