Changeset 38181 in vbox for trunk/src/VBox/Main

Timestamp:

Jul 26, 2011 12:31:09 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

73139

Message:

Main/Progress: optimize forwarding of the progress percentage when nothing changed by avoiding redundant calls which only make the time estimation worse

File:

• trunk/src/VBox/Main/src-all/ProgressImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-all/ProgressImpl.cpp

@@ -931 +931 @@
     BOOL fCompleted      = FALSE;
     BOOL fCanceled       = FALSE;
+    ULONG prevPercent    = UINT32_MAX;
     ULONG currentPercent = 0;
     ULONG cOp            = 0;
@@ -977 +978 @@
                     if (FAILED(rc)) return rc;
                     ++cOp;
-                }else
+                }
+                else
                     break;
             }
@@ -983 +985 @@
             rc = pProgressAsync->COMGETTER(OperationPercent(&currentPercent));
             if (FAILED(rc)) return rc;
-            rc = SetCurrentOperationProgress(currentPercent);
-            if (FAILED(rc)) return rc;
+            if (currentPercent != prevPercent)
+            {
+                prevPercent = currentPercent;
+                rc = SetCurrentOperationProgress(currentPercent);
+                if (FAILED(rc)) return rc;
+            }
         }
         if (fCompleted)