Changeset 38613 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Sep 2, 2011 12:32:23 PM (13 years ago)

Author:

vboxsync

Message:

VMR3ReqProcessU: Deconfused the code a bit.

File:

• trunk/src/VBox/VMM/VMMR3/VMReq.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/VMReq.cpp

@@ -1068 +1068 @@
      *
      * We do not repeat the outer loop if we've got an informational status code
-     * since that code needs processing by our caller.
+     * since that code needs processing by our caller (usually EM).
      */
     int rc = VINF_SUCCESS;
-    while (rc <= VINF_SUCCESS)
+    for (;;)
     {
         /*
@@ -1101 +1101 @@
 
         /*
-         * Process the request.
-         * Note! The status code handling here extremely important and yet very
-         *       fragile.
+         * Process the request
          */
         STAM_COUNTER_INC(&pUVM->vm.s.StatReqProcessed);
         int rc2 = vmR3ReqProcessOneU(pUVM, pReq);
         if (    rc2 >= VINF_EM_FIRST
-            &&  rc2 <= VINF_EM_LAST
-            &&  (   rc == VINF_SUCCESS
-                 || rc2 < rc) )
+            &&  rc2 <= VINF_EM_LAST)
+        {
             rc = rc2;
-        /** @todo may have to abort processing to propagate EM scheduling status codes
-         *        up to the caller... See the ugly hacks after VMMR3EmtRendezvousFF
-         *        and VMR3ReqProcessU in EM.cpp. */
+            break;
+        }
     }