Changeset 38892 in vbox for trunk/src/VBox

Timestamp:

Sep 28, 2011 8:47:43 AM (13 years ago)

Author:

vboxsync

Message:

Additions/common/VBoxGuest: do not send mouse status updates to the host if nothing has changed.

File:

• trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp

@@ -2049 +2049 @@
 
 /**
- * Sets the mouse status features for this session and updates them globally.
+ * Sets the mouse status features for this session and updates them
+ * globally.  We aim to ensure that if several threads call this in
+ * parallel the most recent status will always end up being set.
  *
  * @returns VBox status code.
@@ -2063 +2065 @@
     uint32_t fNewDevExtStatus = 0;
     int rc;
+    /* Exit early if nothing has changed - hack to work around the
+     * Windows Additions not using the common code. */
+    bool fNoAction;
 
     RTSpinlockAcquireNoInts(pDevExt->SessionSpinlock, &Tmp);
@@ -2080 +2085 @@
     }
     pSession->fMouseStatus = fFeatures & VMMDEV_MOUSE_GUEST_MASK;
+    fNoAction = (pDevExt->fMouseStatus == fNewDevExtStatus);
     pDevExt->fMouseStatus = fNewDevExtStatus;
     RTSpinlockReleaseNoInts(pDevExt->SessionSpinlock, &Tmp);
+    if (fNoAction)
+        return VINF_SUCCESS;
     do
     {