Changeset 38928 in vbox for trunk/src/VBox/Frontends

Timestamp:

Oct 2, 2011 8:38:36 PM (14 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

74278

Message:

FE/Qt: re-applied r74233 to trunk: fix spurious left control key events on Windows hosts

Location:

trunk

Files:

• . (modified) (1 prop)
• src/VBox/Frontends/VirtualBox/src/runtime/UIKeyboardHandler.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIKeyboardHandler.cpp

@@ -934 +934 @@
         return false;
 
-    if (!m_fIsKeyboardCaptured)
-        return false;
-
     /* Sometimes it happens that Win inserts additional events on some key
      * press/release. For example, it prepends ALT_GR in German layout with
@@ -954 +951 @@
             return true;
     }
+
+    /** @todo this needs to be after the preceding check so that
+     *        we ignore those spurious key events even when the
+     *        keyboard is not captured.  However, that is probably a
+     *        hint that that filtering should be done somewhere else,
+     *        and not in the keyboard capture handler. */
+    if (!m_fIsKeyboardCaptured)
+        return false;
 
     /* It's possible that a key has been pressed while the keyboard was not