Changeset 38978 in vbox for trunk/src/VBox/Frontends

Timestamp:

Oct 12, 2011 1:33:28 PM (13 years ago)

Author:

vboxsync

Message:

FE/Qt: send guest size hints on fullscreen/seamless exit after the normal view window has been created

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/VBoxDefs.cpp (modified) (1 diff)
• globals/VBoxDefs.h (modified) (1 diff)
• runtime/UIMachineView.cpp (modified) (4 diffs)
• runtime/UIMachineView.h (modified) (1 diff)
• runtime/fullscreen/UIMachineViewFullscreen.cpp (modified) (6 diffs)
• runtime/fullscreen/UIMachineViewFullscreen.h (modified) (2 diffs)
• runtime/normal/UIMachineViewNormal.cpp (modified) (2 diffs)
• runtime/normal/UIMachineViewNormal.h (modified) (1 diff)
• runtime/seamless/UIMachineViewSeamless.cpp (modified) (4 diffs)
• runtime/seamless/UIMachineViewSeamless.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxDefs.cpp

@@ -33 +33 @@
 const char* VBoxDefs::GUI_LastWindowState_Max = "max";
 const char* VBoxDefs::GUI_LastGuestSizeHint = "GUI/LastGuestSizeHint";
+const char* VBoxDefs::GUI_LastGuestSizeHintWasFullscreen = "GUI/LastGuestSizeHintWasFullscreen";
 const char* VBoxDefs::GUI_Toolbar = "GUI/Toolbar";
 const char* VBoxDefs::GUI_Statusbar = "GUI/Statusbar";

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxDefs.h

@@ -116 +116 @@
     static const char* GUI_Statusbar;
     static const char* GUI_LastGuestSizeHint;
+    static const char* GUI_LastGuestSizeHintWasFullscreen;
     static const char* GUI_Fullscreen;
     static const char* GUI_Seamless;

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.cpp

@@ -113 +113 @@
 #endif /* VBOX_WITH_VIDEOHWACCEL */
                                                        );
+            pMachineView->m_fIsFullscreen = true;
             break;
         case UIVisualStateType_Seamless:
@@ -121 +122 @@
 #endif /* VBOX_WITH_VIDEOHWACCEL */
                                                      );
+            pMachineView->m_fIsFullscreen = true;
             break;
         case UIVisualStateType_Scale:
@@ -160 +162 @@
     /* Send new size-hint to the guest: */
     session().GetConsole().GetDisplay().SetVideoModeHint(newSize.width(), newSize.height(), 0, screenId());
+    /* And track whether we have had a "normal" resize since the last
+     * fullscreen resize hint was sent: */
+    machine.SetExtraData(VBoxDefs::GUI_LastGuestSizeHintWasFullscreen,
+                         m_fIsFullscreen ? "true" : "");
 }
 
@@ -226 +232 @@
                              )
     : QAbstractScrollArea(pMachineWindow->machineWindow())
+    , m_fIsFullscreen(false)
     , m_pMachineWindow(pMachineWindow)
     , m_uScreenId(uScreenId)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.h

@@ -71 +71 @@
     /* Utility signals: */
     void resizeHintDone();
+
+private:
+
+    /** Is this a fullscreen-type view? */
+    bool m_fIsFullscreen;
 
 protected slots:

trunk/src/VBox/Frontends/VirtualBox/src/runtime/fullscreen/UIMachineViewFullscreen.cpp

@@ -52 +52 @@
                     )
     , m_bIsGuestAutoresizeEnabled(gActionPool->action(UIActionIndexRuntime_Toggle_GuestAutoresize)->isChecked())
-    , m_pSyncBlocker(0)
 {
     /* Load machine view settings: */
@@ -72 +71 @@
     prepareConsoleConnections();
 
-    /* Prepare fullscreen: */
-    prepareFullscreen();
-
     /* Initialization: */
     sltMachineStateChanged();
@@ -81 +77 @@
 UIMachineViewFullscreen::~UIMachineViewFullscreen()
 {
-    /* Cleanup fullscreen: */
-    cleanupFullscreen();
-
     /* Cleanup frame buffer: */
     cleanupFrameBuffer();
@@ -153 +146 @@
             emit resizeHintDone();
 
-            /* Unlock after processing guest resize event: */
-            if (m_pSyncBlocker && m_pSyncBlocker->isRunning())
-                m_pSyncBlocker->quit();
-
             pEvent->accept();
             return true;
@@ -181 +170 @@
                 /* Send guest-resize hint only if top window resizing to required dimension: */
                 QResizeEvent *pResizeEvent = static_cast<QResizeEvent*>(pEvent);
+                /** @todo why is this here?  If it is a workaround
+                 * for some situation that should be documented. */
                 if (pResizeEvent->size() != workingArea().size())
                     break;
@@ -239 +230 @@
 }
 
-void UIMachineViewFullscreen::prepareFullscreen()
-{
-    /* Create sync-blocker: */
-    m_pSyncBlocker = new UIMachineViewBlocker;
-}
-
-void UIMachineViewFullscreen::cleanupFullscreen()
-{
-    /* If machine still running: */
-    if (uisession()->isRunning())
-    {
-        /* And guest supports advanced graphics management which is enabled: */
-        if (m_bIsGuestAutoresizeEnabled && uisession()->isGuestSupportsGraphics())
-        {
-            /* Rollback seamless frame-buffer size to normal: */
-            machineWindowWrapper()->machineWindow()->hide();
-            sltPerformGuestResize(guestSizeHint());
-            m_pSyncBlocker->exec();
-
-            /* Request to delete sync-blocker: */
-            m_pSyncBlocker->deleteLater();
-        }
-    }
-}
-
 void UIMachineViewFullscreen::setGuestAutoresizeEnabled(bool fEnabled)
 {

trunk/src/VBox/Frontends/VirtualBox/src/runtime/fullscreen/UIMachineViewFullscreen.h

@@ -58 +58 @@
     void prepareConnections();
     void prepareConsoleConnections();
-    void prepareFullscreen();
 
     /* Cleanup routines: */
-    void cleanupFullscreen();
     //void cleanupConsoleConnections() {}
     //void cleanupConnections() {}
@@ -78 +76 @@
     /* Private variables: */
     bool m_bIsGuestAutoresizeEnabled : 1;
-    UIMachineViewBlocker *m_pSyncBlocker;
 
     /* Friend classes: */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/normal/UIMachineViewNormal.cpp

@@ -88 +88 @@
     /* Check if we should restrict minimum size: */
     maybeRestrictMinimumSize();
+
+    /* Resend the last resize hint if there was a fullscreen or
+     * seamless transition previously.  If we were not in graphical
+     * mode initially after the transition this happens when we
+     * switch. */
+    maybeResendResizeHint();
 }
 
@@ -253 +259 @@
 }
 
+void UIMachineViewNormal::maybeResendResizeHint()
+{
+    if (m_bIsGuestAutoresizeEnabled && uisession()->isGuestSupportsGraphics())
+    {
+        /* Get the current machine: */
+        CMachine machine = session().GetMachine();
+
+        /* We send a guest size hint if needed to reverse a transition
+         * to fullscreen or seamless. */
+        QString strHintSent = machine.GetExtraData(VBoxDefs::GUI_LastGuestSizeHintWasFullscreen);
+        if (!strHintSent.isEmpty())
+            sltPerformGuestResize(guestSizeHint());
+    }
+}
+
 void UIMachineViewNormal::saveMachineViewSettings()
 {

trunk/src/VBox/Frontends/VirtualBox/src/runtime/normal/UIMachineViewNormal.h

@@ -65 +65 @@
     void prepareConsoleConnections();
     //void loadMachineViewSettings();
+    void maybeResendResizeHint();
 
     /* Cleanup helpers: */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/seamless/UIMachineViewSeamless.cpp

@@ -50 +50 @@
 #endif
                     )
-    , m_pSyncBlocker(0)
 {
     /* Load machine view settings: */
@@ -160 +159 @@
             /* Emit a signal about guest was resized: */
             emit resizeHintDone();
-
-            /* Unlock after processing guest resize event: */
-            if (m_pSyncBlocker && m_pSyncBlocker->isRunning())
-                m_pSyncBlocker->quit();
 
             pEvent->accept();
@@ -251 +246 @@
     /* Set seamless feature flag to the guest: */
     session().GetConsole().GetDisplay().SetSeamlessMode(true);
-    /* Create sync-blocker: */
-    m_pSyncBlocker = new UIMachineViewBlocker;
 }
 
@@ -259 +252 @@
     /* If machine still running: */
     if (uisession()->isRunning())
-    {
         /* Reset seamless feature flag of the guest: */
         session().GetConsole().GetDisplay().SetSeamlessMode(false);
-
-        /* Rollback seamless frame-buffer size to normal: */
-        machineWindowWrapper()->machineWindow()->hide();
-        sltPerformGuestResize(guestSizeHint());
-        m_pSyncBlocker->exec();
-
-        /* Delete sync-blocker: */
-        m_pSyncBlocker->deleteLater();
-    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/runtime/seamless/UIMachineViewSeamless.h

@@ -80 +80 @@
     /* Private variables: */
     QRegion m_lastVisibleRegion;
-    UIMachineViewBlocker *m_pSyncBlocker;
 
     /* Friend classes: */