Changeset 39083 in vbox for trunk/src/VBox/Runtime/common/dbg

Timestamp:

Oct 22, 2011 12:28:46 AM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

74515

Message:

IPRT: -Wunused-parameter.

Location:

trunk/src/VBox/Runtime/common/dbg

Files:

• dbgmod.cpp (modified) (5 diffs)
• dbgmodcontainer.cpp (modified) (3 diffs)
• dbgmoddwarf.cpp (modified) (15 diffs)
• dbgmodldr.cpp (modified) (1 diff)
• dbgmodnm.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/common/dbg/dbgmod.cpp

@@ -129 +129 @@
 static DECLCALLBACK(void) rtDbgModTermCallback(RTTERMREASON enmReason, int32_t iStatus, void *pvUser)
 {
+    NOREF(iStatus); NOREF(pvUser);
     if (enmReason == RTTERMREASON_UNLOAD)
     {
@@ -258 +259 @@
 static DECLCALLBACK(int) rtDbgModInitOnce(void *pvUser1, void *pvUser2)
 {
+    NOREF(pvUser1); NOREF(pvUser2);
+
     /*
      * Create the semaphore and string cache.
@@ -362 +365 @@
 
 
-RTDECL(int)         RTDbgModCreateDeferred(PRTDBGMOD phDbgMod, const char *pszFilename, const char *pszName, RTUINTPTR cb, uint32_t fFlags)
-{
+RTDECL(int) RTDbgModCreateDeferred(PRTDBGMOD phDbgMod, const char *pszFilename, const char *pszName,
+                                   RTUINTPTR cb, uint32_t fFlags)
+{
+    NOREF(phDbgMod); NOREF(pszFilename); NOREF(pszName); NOREF(cb); NOREF(fFlags);
     return VERR_NOT_IMPLEMENTED;
 }
@@ -501 +506 @@
 
 
-RTDECL(int) RTDbgModCreateFromMap(PRTDBGMOD phDbgMod, const char *pszFilename, const char *pszName, RTUINTPTR uSubtrahend, uint32_t fFlags)
+RTDECL(int) RTDbgModCreateFromMap(PRTDBGMOD phDbgMod, const char *pszFilename, const char *pszName,
+                                  RTUINTPTR uSubtrahend, uint32_t fFlags)
 {
     /*
@@ -512 +518 @@
     AssertPtrNullReturn(pszName, VERR_INVALID_POINTER);
     AssertReturn(fFlags == 0, VERR_INVALID_PARAMETER);
+    AssertReturn(uSubtrahend == 0, VERR_NOT_IMPLEMENTED); /** @todo implement uSubtrahend. */
 
     int rc = rtDbgModLazyInit();

trunk/src/VBox/Runtime/common/dbg/dbgmodcontainer.cpp

@@ -400 +400 @@
     pSymbol->cb                 = cb;
     pSymbol->fFlags             = fFlags;
-    pSymbol->NameCore.pszString = RTStrCacheEnter(g_hDbgModStrCache, pszSymbol);
+    pSymbol->NameCore.pszString = RTStrCacheEnterN(g_hDbgModStrCache, pszSymbol, cchSymbol);
     int rc;
     if (pSymbol->NameCore.pszString)
@@ -604 +604 @@
     pSym->NameCore.pszString = NULL;
     RTMemFree(pSym);
+    NOREF(pvUser);
     return 0;
 }
@@ -638 +639 @@
 static DECLCALLBACK(int) rtDbgModContainer_TryOpen(PRTDBGMODINT pMod)
 {
+    NOREF(pMod);
     return VERR_INTERNAL_ERROR_5;
 }

trunk/src/VBox/Runtime/common/dbg/dbgmoddwarf.cpp

@@ -827 +827 @@
     Log(("Segment %.*s: LinkAddress=%#llx RVA=%#llx cb=%#llx\n",
          pSeg->cchName, pSeg->pchName, (uint64_t)pSeg->LinkAddress, (uint64_t)pSeg->RVA, pSeg->cb));
+    NOREF(hLdrMod);
     RTLDRADDR cb = RT_MAX(pSeg->cb, pSeg->cbMapped);
 #if 1
@@ -922 +923 @@
 static int rtDbgModDwarfStringToUtf8(PRTDBGMODDWARF pThis, char **ppsz)
 {
+    /** @todo DWARF & UTF-8. */
+    NOREF(pThis);
     RTStrPurgeEncoding(*ppsz);
     return VINF_SUCCESS;
@@ -1731 +1734 @@
                         ? pLnState->papszFileNames[pLnState->Regs.iFile]
                         : "<bad file name index>";
+    NOREF(offOpCode);
+
     RTDBGSEGIDX iSeg;
     RTUINTPTR   offSeg;
@@ -2437 +2442 @@
 {
     AssertReturn(ATTR_GET_SIZE(pDesc) == sizeof(RTDWARFADDR), VERR_INTERNAL_ERROR_3);
+    NOREF(pDie);
 
     uint64_t uAddr;
@@ -2465 +2471 @@
 {
     AssertReturn(ATTR_GET_SIZE(pDesc) == sizeof(bool), VERR_INTERNAL_ERROR_3);
+    NOREF(pDie);
 
     bool *pfMember = (bool *)pbMember;
@@ -2496 +2503 @@
     AssertReturn(ATTR_GET_SIZE(pDesc) == sizeof(RTDWARFADDRRANGE), VERR_INTERNAL_ERROR_3);
     AssertReturn(pDesc->uAttr == DW_AT_low_pc || pDesc->uAttr == DW_AT_high_pc, VERR_INTERNAL_ERROR_3);
+    NOREF(pDie);
 
     uint64_t uAddr;
@@ -2545 +2553 @@
     AssertReturn(ATTR_GET_SIZE(pDesc) == sizeof(RTDWARFADDRRANGE), VERR_INTERNAL_ERROR_3);
     AssertReturn(pDesc->uAttr == DW_AT_low_pc || pDesc->uAttr == DW_AT_high_pc, VERR_INTERNAL_ERROR_3);
+    NOREF(pDie);
 
     /* Decode it. */
@@ -2658 +2667 @@
 {
     AssertReturn(ATTR_GET_SIZE(pDesc) == sizeof(RTDWARFREF), VERR_INTERNAL_ERROR_3);
+    NOREF(pDie);
 
     uint64_t off;
@@ -2699 +2709 @@
 {
     AssertReturn(ATTR_GET_SIZE(pDesc) == sizeof(const char *), VERR_INTERNAL_ERROR_3);
+    NOREF(pDie);
 
     switch (uForm)
@@ -2722 +2733 @@
                                                    uint32_t uForm, PRTDWARFCURSOR pCursor)
 {
+    NOREF(pDie);
     uint64_t u64Val;
     switch (uForm)
@@ -2888 +2900 @@
                                       PCRTDWARFABBREV pAbbrev, PRTDWARFDIE pParent)
 {
+    NOREF(pThis);
     Assert(pDieDesc->cbDie >= sizeof(RTDWARFDIE));
     PRTDWARFDIE pDie = (PRTDWARFDIE)RTMemAllocZ(pDieDesc->cbDie);
@@ -3282 +3295 @@
 {
     PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pMod->pvDbgPriv;
+    Assert(!pszFile[cchFile]); NOREF(cchFile);
     return RTDbgModLineAdd(pThis->hCnt, pszFile, uLineNo, iSeg, off, piOrdinal);
 }
@@ -3327 +3341 @@
 {
     PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pMod->pvDbgPriv;
+    Assert(!pszSymbol[cchSymbol]); NOREF(cchSymbol);
     return RTDbgModSymbolAdd(pThis->hCnt, pszSymbol, iSeg, off, cb, fFlags, piOrdinal);
 }
@@ -3352 +3367 @@
 {
     PRTDBGMODDWARF pThis = (PRTDBGMODDWARF)pMod->pvDbgPriv;
+    Assert(!pszName[cchName]); NOREF(cchName);
     return RTDbgModSegmentAdd(pThis->hCnt, uRva, cb, pszName, fFlags, piSeg);
 }
@@ -3397 +3413 @@
                                                    const char *pszExtFile, void *pvUser)
 {
+    NOREF(hLdrMod); NOREF(iDbgInfo); NOREF(iMajorVer); NOREF(iMinorVer); NOREF(LinkAddress);
+
     /*
      * Skip stuff we can't handle.

trunk/src/VBox/Runtime/common/dbg/dbgmodldr.cpp

@@ -64 +64 @@
 static DECLCALLBACK(int) rtDbgModLdr_UnmapPart(PRTDBGMODINT pMod, size_t cb, void const **ppvMap)
 {
+    NOREF(pMod); NOREF(cb);
     RTMemFree((void *)*ppvMap);
     *ppvMap = NULL;

trunk/src/VBox/Runtime/common/dbg/dbgmodnm.cpp

@@ -86 +86 @@
 {
     PRTDBGMODNM pThis = (PRTDBGMODNM)pMod->pvDbgPriv;
+    Assert(!pszFile[cchFile]); NOREF(cchFile);
     return RTDbgModLineAdd(pThis->hCnt, pszFile, uLineNo, iSeg, off, piOrdinal);
 }
@@ -100 +101 @@
 
 /** @interface_method_impl{RTDBGMODVTDBG,pfnSymbolByName} */
-static DECLCALLBACK(int) rtDbgModNm_SymbolByName(PRTDBGMODINT pMod, const char *pszSymbol, size_t cchSymbol, PRTDBGSYMBOL pSymInfo)
-{
-    PRTDBGMODNM pThis = (PRTDBGMODNM)pMod->pvDbgPriv;
+static DECLCALLBACK(int) rtDbgModNm_SymbolByName(PRTDBGMODINT pMod, const char *pszSymbol, size_t cchSymbol,
+                                                 PRTDBGSYMBOL pSymInfo)
+{
+    PRTDBGMODNM pThis = (PRTDBGMODNM)pMod->pvDbgPriv;
+    Assert(!pszSymbol[cchSymbol]); NOREF(cchSymbol);
     return RTDbgModSymbolByName(pThis->hCnt, pszSymbol, pSymInfo);
 }
@@ -129 +132 @@
 {
     PRTDBGMODNM pThis = (PRTDBGMODNM)pMod->pvDbgPriv;
+    Assert(!pszSymbol[cchSymbol]); NOREF(cchSymbol);
     return RTDbgModSymbolAdd(pThis->hCnt, pszSymbol, iSeg, off, cb, fFlags, piOrdinal);
 }
@@ -150 +154 @@
 
 /** @interface_method_impl{RTDBGMODVTDBG,pfnSegmentAdd} */
-static DECLCALLBACK(int) rtDbgModNm_SegmentAdd(PRTDBGMODINT pMod, RTUINTPTR uRva, RTUINTPTR cb, const char *pszName, size_t cchName,
-                                               uint32_t fFlags, PRTDBGSEGIDX piSeg)
-{
-    PRTDBGMODNM pThis = (PRTDBGMODNM)pMod->pvDbgPriv;
+static DECLCALLBACK(int) rtDbgModNm_SegmentAdd(PRTDBGMODINT pMod, RTUINTPTR uRva, RTUINTPTR cb, const char *pszName,
+                                               size_t cchName, uint32_t fFlags, PRTDBGSEGIDX piSeg)
+{
+    PRTDBGMODNM pThis = (PRTDBGMODNM)pMod->pvDbgPriv;
+    Assert(!pszName[cchName]); NOREF(cchName);
     return RTDbgModSegmentAdd(pThis->hCnt, uRva, cb, pszName, fFlags, piSeg);
 }