Changeset 39427 in vbox for trunk/src/VBox/HostServices/GuestControl

Timestamp:

Nov 25, 2011 2:29:43 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

75056

Message:

r=bird: pre-review comments.

File:

• trunk/src/VBox/HostServices/GuestControl/service.cpp (modified) (4 diffs)

trunk/src/VBox/HostServices/GuestControl/service.cpp

@@ -430 +430 @@
         for (uint32_t i = 0; i < pBuf->uParmCount; i++)
         {
+            /** @todo r=bird: Should this CHECK the type instead of overriding
+             * it?? What happens if a guest initializes a PTR param as a 32-bit
+             * or 64-bit value with a non-zero value? You'll crash and burn in
+             * the memcpy below! */
             paParms[i].type = pBuf->pParms[i].type;
             switch (paParms[i].type)
@@ -439 +443 @@
                 case VBOX_HGCM_SVC_PARM_64BIT:
                     /* Not supported yet. */
+                    /** @todo r=bird: This case needs to fail! */
                     break;
 
@@ -458 +463 @@
 
                 default:
+                    /** @todo r=bird: This case needs to fail! */
                     break;
             }
@@ -589 +595 @@
  *
  * @return  IPRT status code.
- * @param   pCmd                    Host comamnd to send.
+ * @param   pCmd                    Host command to send.
  * @param   callHandle              Call handle of the client to send the command to.
  * @param   cParms                  Number of parameters.