Changeset 39507 in vbox for trunk/src/VBox/GuestHost/OpenGL/include

Timestamp:

Dec 2, 2011 7:44:16 AM (13 years ago)

Author:

vboxsync

Message:

crOpenGL: fix destroyed context refference in TLS

File:

• trunk/src/VBox/GuestHost/OpenGL/include/cr_glstate.h (modified) (2 diffs)

trunk/src/VBox/GuestHost/OpenGL/include/cr_glstate.h

@@ -118 +118 @@
 struct CRContext {
     int id;
+
+#ifdef CHROMIUM_THREADSAFE
+    /* we keep reference counting of context's makeCurrent for different threads
+     * this is primarily needed to avoid having an invalid memory reference in the TLS
+     * when the context is assigned to more than one threads and then destroyed from
+     * one of those, i.e.
+     * 1. Thread1 -> MakeCurrent(ctx1);
+     * 2. Thread2 -> MakeCurrent(ctx1);
+     * 3. Thread1 -> Destroy(ctx1);
+     * => Thread2 still refers to destroyed ctx1
+     * */
+    /* number of threads that have context set as current */
+    volatile int cRefs;
+#endif
+
     CRbitvalue bitid[CR_MAX_BITARRAY];
     CRbitvalue neg_bitid[CR_MAX_BITARRAY];
@@ -181 +196 @@
 DECLEXPORT(void) crStateInit(void);
 DECLEXPORT(void) crStateDestroy(void);
+DECLEXPORT(void) crStateOnThreadAttachDetach(GLboolean attach);
 DECLEXPORT(CRContext *) crStateCreateContext(const CRLimitsState *limits, GLint visBits, CRContext *share);
 DECLEXPORT(CRContext *) crStateCreateContextEx(const CRLimitsState *limits, GLint visBits, CRContext *share, GLint presetID);