Changeset 39619 in vbox for trunk/src/VBox/Devices/PC/BIOS-new

Timestamp:

Dec 14, 2011 5:36:18 PM (13 years ago)

Author:

vboxsync

Message:

16 bits is plenty for the AHCI index register.

File:

• trunk/src/VBox/Devices/PC/BIOS-new/ahci.c (modified) (5 diffs)

trunk/src/VBox/Devices/PC/BIOS-new/ahci.c

@@ -141 +141 @@
 
 /** Returns the absolute register offset from a given port and port register. */
-#define AHCI_PORT_REG(port, reg)    ((uint32_t)(AHCI_HBA_SIZE + (port) * AHCI_PORT_SIZE + (reg)))
+#define AHCI_PORT_REG(port, reg)    (AHCI_HBA_SIZE + (port) * AHCI_PORT_SIZE + (reg))
 
 #define AHCI_REG_IDX   0
@@ -147 +147 @@
 
 /** Writes the given value to a AHCI register. */
-#define AHCI_WRITE_REG(iobase, reg, val)                \
-    outpd((iobase) + AHCI_REG_IDX, (uint32_t)(reg));    \
-    outpd((iobase) + AHCI_REG_DATA, (uint32_t)(val))
+#define AHCI_WRITE_REG(iobase, reg, val)    \
+    outpd((iobase) + AHCI_REG_IDX, reg);    \
+    outpd((iobase) + AHCI_REG_DATA, val)
 
 /** Reads from a AHCI register. */
-#define AHCI_READ_REG(iobase, reg, val)                 \
-    outpd((iobase) + AHCI_REG_IDX, (uint32_t)(reg));    \
+#define AHCI_READ_REG(iobase, reg, val)     \
+    outpd((iobase) + AHCI_REG_IDX, reg);    \
     (val) = inpd((iobase) + AHCI_REG_DATA)
 
@@ -224 +224 @@
  * Sets a given set of bits in a register.
  */
-static void ahci_ctrl_set_bits(uint16_t iobase, uint32_t reg, uint32_t mask)
+static void ahci_ctrl_set_bits(uint16_t iobase, uint16_t reg, uint32_t mask)
 {
     outpd(iobase + AHCI_REG_IDX, reg);
@@ -233 +233 @@
  * Clears a given set of bits in a register.
  */
-static void ahci_ctrl_clear_bits(uint16_t iobase, uint32_t reg, uint32_t mask)
+static void ahci_ctrl_clear_bits(uint16_t iobase, uint16_t reg, uint32_t mask)
 {
     outpd(iobase + AHCI_REG_IDX, reg);
@@ -243 +243 @@
  * for a register.
  */
-static uint8_t ahci_ctrl_is_bit_set(uint16_t iobase, uint32_t reg, uint32_t mask)
+static uint8_t ahci_ctrl_is_bit_set(uint16_t iobase, uint16_t reg, uint32_t mask)
 {
     outpd(iobase + AHCI_REG_IDX, reg);