Changeset 39711 in vbox

Timestamp:

Jan 6, 2012 5:58:41 PM (13 years ago)

Author:

vboxsync

Message:

Disabled the mCallbackData cache until it's purpose has been found.

Location:

trunk/src/VBox/Main

Files:

• include/ConsoleImpl.h (modified) (4 diffs)
• src-client/ConsoleImpl.cpp (modified) (8 diffs)

trunk/src/VBox/Main/include/ConsoleImpl.h

@@ -790 +790 @@
     ComObjPtr<Progress> mptrCancelableProgress;
 
+    /* The purpose of caching of some events is probably in order to
+       automatically fire them at new event listeners.  However, there is no
+       (longer?) any code making use of this... */
+#ifdef CONSOLE_WITH_EVENT_CACHE
     struct
     {
@@ -803 +807 @@
             uint32_t height;
             com::SafeArray<BYTE> shape;
-        }
-        mpsc;
+        } mpsc;
 
         /** OnMouseCapabilityChange() cache */
@@ -813 +816 @@
             BOOL supportsRelative;
             BOOL needsHostCursor;
-        }
-        mcc;
+        } mcc;
 
         /** OnKeyboardLedsChange() cache */
@@ -823 +825 @@
             bool capsLock;
             bool scrollLock;
-        }
-        klc;
+        } klc;
 
         void clear()
         {
-            /* We cannot do memset() on mpsc to avoid cleaning shape's vtable */
+            RT_ZERO(mcc);
+            RT_ZERO(klc);
+
+            /* We cannot RT_ZERO mpsc because of shape's vtable. */
             mpsc.shape.setNull();
             mpsc.valid = mpsc.visible = mpsc.alpha = false;
             mpsc.xHot = mpsc.yHot = mpsc.width = mpsc.height = 0;
-            ::memset(&mcc, 0, sizeof mcc);
-            ::memset(&klc, 0, sizeof klc);
         }
-    }
-    mCallbackData;
+    } mCallbackData;
+#endif
     ComPtr<IEventListener> mVmListener;
 

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -699 +699 @@
     unconst(mEventSource).setNull();
 
+#ifdef CONSOLE_WITH_EVENT_CACHE
     mCallbackData.clear();
+#endif
 
     LogFlowThisFuncLeave();
@@ -5700 +5702 @@
     AssertComRCReturnVoid(autoCaller.rc());
 
+#ifndef CONSOLE_WITH_EVENT_CACHE
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+#else
     /* We need a write lock because we alter the cached callback data */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
@@ -5721 +5726 @@
         mCallbackData.mpsc.shape.resize(0);
     mCallbackData.mpsc.valid = true;
+#endif
 
     fireMousePointerShapeChangedEvent(mEventSource, fVisible, fAlpha, xHot, yHot, width, height, ComSafeArrayInArg(pShape));
@@ -5740 +5746 @@
     AssertComRCReturnVoid(autoCaller.rc());
 
+#ifndef CONSOLE_WITH_EVENT_CACHE
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+#else
     /* We need a write lock because we alter the cached callback data */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
@@ -5748 +5757 @@
     mCallbackData.mcc.needsHostCursor = needsHostCursor;
     mCallbackData.mcc.valid = true;
+#endif
 
     fireMouseCapabilityChangedEvent(mEventSource, supportsAbsolute, supportsRelative, needsHostCursor);
@@ -5800 +5810 @@
     AssertComRCReturnVoid(autoCaller.rc());
 
+#ifndef CONSOLE_WITH_EVENT_CACHE
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+#else
     /* We need a write lock because we alter the cached callback data */
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
@@ -5808 +5821 @@
     mCallbackData.klc.scrollLock = fScrollLock;
     mCallbackData.klc.valid = true;
+#endif
 
     fireKeyboardLedsChangedEvent(mEventSource, fNumLock, fCapsLock, fScrollLock);
@@ -6925 +6939 @@
         mVMDestroying = false;
 
+#ifdef CONSOLE_WITH_EVENT_CACHE
     if (SUCCEEDED(rc))
         mCallbackData.clear();
+#endif
 
     LogFlowThisFuncLeave();