Changeset 39804 in vbox

Timestamp:

Jan 19, 2012 9:41:09 AM (13 years ago)

Author:

vboxsync

Message:

Fixed regression (I hope) in yesterdays tcp/socket changes (name resolution).

Location:

trunk

Files:

• include/iprt/socket.h (modified) (1 diff)
• src/VBox/Runtime/r3/socket.cpp (modified) (2 diffs)

trunk/include/iprt/socket.h

@@ -118 +118 @@
  *
  * @returns IPRT status code
- * @param   pszAddress      Name or IP address.
+ * @param   pszAddress      Name or IP address.  NULL or empty string (no
+ *                          spaces) is taken to mean INADDR_ANY, which is
+ *                          meaningful when binding a server socket for
+ *                          instance.
  * @param   uPort           Port number (host byte order).
  * @param   pAddr           Where to return the generic IPRT network address.

trunk/src/VBox/Runtime/r3/socket.cpp

@@ -623 +623 @@
      */
     AssertReturn(uPort > 0, VERR_INVALID_PARAMETER);
-    AssertPtrReturn(pszAddress, VERR_INVALID_POINTER);
+    AssertPtrNullReturn(pszAddress, VERR_INVALID_POINTER);
 
 #ifdef RT_OS_WINDOWS
@@ -647 +647 @@
      * It probably needs to be converted to getaddrinfo(). */
     RTNETADDRIPV4 IPv4Quad;
-    if (rtSocketIsIPv4Numerical(pszAddress, &IPv4Quad))
+    if (   !pszAddress
+        || rtSocketIsIPv4Numerical(pszAddress, &IPv4Quad))
     {
         Log3(("rtSocketIsIPv4Numerical: %#x (%RTnaipv4)\n", pszAddress, IPv4Quad.u, IPv4Quad));