Changeset 39805 in vbox for trunk/src/VBox

Timestamp:

Jan 19, 2012 10:38:36 AM (13 years ago)

Author:

vboxsync

Message:

GuestImpl.cpp: Runlevel todos.

Location:

trunk/src/VBox/Main

Files:

• include/AdditionsFacilityImpl.h (modified) (1 diff)
• src-client/GuestImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/include/AdditionsFacilityImpl.h

@@ -1 +1 @@
 /** @file
- *
  * VirtualBox COM class implementation
  */

trunk/src/VBox/Main/src-client/GuestImpl.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2006-2011 Oracle Corporation
+ * Copyright (C) 2006-2012 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -866 +866 @@
         AssertMsgFailed(("Invalid facility status/run level detected! uCurFacility=%d\n", uCurFacility));
 
+    /** @todo Above is wrong. The runlevel has to be recalculated from the
+     *        facilities.  A user can stop VBoxService before logging out.
+     *        The runlevel should then drop to System, not Userland.
+     *
+     * Also, if given enmFacility = VBoxGuestFacilityType_Unknown, we'll be
+     * bosting the runlevel to Desktop (0 - 1 = UINT32_MAX; UINT32_MAX >=
+     * VBoxGuestFacilityType_VBoxTrayClient). */
+
+    /** @todo VBoxGuest (the driver) should track VMMDevReq_ReportGuestStatus
+     * calls per session and automatically send VBoxGuestFacilityStatus_Failed
+     * for the facilites that does not have the status
+     * VBoxGuestFacilityStatus_Terminated, VBoxGuestFacilityStatus_Failed or
+     * VBoxGuestFacilityStatus_Inactive.  Not doing so means this
+     * information is not reliable. */
+
     /*
      * Set a specific facility status.