Changeset 39817 in vbox for trunk/src/libs/xpcom18a4/nsprpub

Timestamp:

Jan 20, 2012 12:51:58 PM (13 years ago)

Author:

vboxsync

Message:

PR_GetInheritedFD: Potential read access beyond the end of the string.

File:

• trunk/src/libs/xpcom18a4/nsprpub/pr/src/misc/prinit.c (modified) (1 diff)

trunk/src/libs/xpcom18a4/nsprpub/pr/src/misc/prinit.c

@@ -681 +681 @@
     ptr = envVar;
     while (1) {
-        if ((ptr[len] == ':') && (strncmp(ptr, name, len) == 0)) {
+        if ((strncmp(ptr, name, len) == 0) && (ptr[len] == ':')) {
             ptr += len + 1;
             PR_sscanf(ptr, "%d:0x%lx", &fileType, &osfd);