Changeset 39842 in vbox

Timestamp:

Jan 23, 2012 6:21:18 PM (13 years ago)

Author:

vboxsync

Message:

IPRT/process-win: Fixed handle leak on legacy APIs; check rc when unloading user profile to detect non-closed handles more quickly.

File:

• trunk/src/VBox/Runtime/r3/win/process-win.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/win/process-win.cpp

@@ -522 +522 @@
                     }
                 }
+                RTLdrClose(hPSAPI);
             }
         }
@@ -938 +939 @@
 
                                 if (!(fFlags & RTPROC_FLAGS_NO_PROFILE))
-                                    pfnUnloadUserProfile(*phToken, profileInfo.hProfile);
+                                {
+                                    fRc = pfnUnloadUserProfile(*phToken, profileInfo.hProfile);
+                                    if (!fRc)
+                                    {
+                                        /* In case there were some handles left open, we want to know about
+                                         * that -- can be tricky to debug later! */
+                                        DWORD dwErr2 = GetLastError();
+                                        AssertMsgFailed(("Unloading user profile failed with error %ld", dwErr2));
+                                        if (dwErr == NO_ERROR)
+                                            dwErr = dwErr2;
+                                    }
+                                }
                             }
                         }