Changeset 39883 in vbox for trunk

Timestamp:

Jan 26, 2012 8:11:00 AM (13 years ago)

Author:

vboxsync

Message:

NAT:ARP: reserved ARP WHO HAS 0.0.0.0 diagnosys for myself.
o WHO HAS 0.0.0.0 is warning that something processed incorrectly and need to be envestigated.

Warning appears once at release logs.

File:

• trunk/src/VBox/Devices/Network/slirp/slirp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/slirp.c

@@ -2128 +2128 @@
     struct ethhdr *ehdr;
     struct arphdr *ahdr;
+    static bool   fWarned = false;
     LogFlowFunc(("ENTER: %RTnaipv4\n", dst));
+
+    /* ARP request WHO HAS 0.0.0.0 is one of the signals
+     * that something has been broken at Slirp. Investigating
+     * pcap dumps it's easy to miss warning ARP requests being
+     * focused on investigation of other protocols flow.
+     */
+#ifdef DEBUG_vvl
+    Assert((dst != INADDR_ANY));
+    NOREF(fWarned);
+#else
+    if (   dst == INADDR_ANY
+        && !fWarned)
+    {
+        LogRel(("NAT:ARP: \"WHO HAS INADDR_ANY\" request has been detected\n"));
+        fWarned = true;
+    }
+#endif /* !DEBUG_vvl */
 
     m = m_getcl(pData, M_NOWAIT, MT_HEADER, M_PKTHDR);