Changeset 39884 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Jan 26, 2012 9:08:48 AM (13 years ago)

Author:

vboxsync

Message:

NAT:TCP:tcp_output uninitiolized template detection and warning once at release log.

File:

• trunk/src/VBox/Devices/Network/slirp/tcp_output.c (modified) (2 diffs)

trunk/src/VBox/Devices/Network/slirp/tcp_output.c

@@ -448 +448 @@
     else
     {
+        bool fUninitiolizedTemplate = false;
         if (tp->t_flags & TF_ACKNOW)
             tcpstat.tcps_sndacks++;
@@ -487 +488 @@
         m->m_pkthdr.header = mtod(m, void *);
         m->m_len = hdrlen;
-        /* fill template from socket structure */
-        tcp_template(tp);
+        /*
+         * Uninitialized TCP template looks very suspicious at this processing state, thus why we have
+         * to workaround the problem till right fix. Warning appears once at release log.
+         */
+        fUninitiolizedTemplate = RT_BOOL((   tp->t_template.ti_src.s_addr == INADDR_ANY
+                                          || tp->t_template.ti_dst.s_addr == INADDR_ANY));
+#ifndef DEBUG_vvl
+        if (fUninitiolizedTemplate)
+        {
+            static bool fWarn;
+            tcp_template(tp);
+            if(!fWarn)
+            {
+                LogRel(("NAT:TCP: TCP template was created forcely from socket information\n"));
+                fWarn = true;
+            }
+        }
+#else
+        Assert((!fUninitiolizedTemplate));
+#endif
     }