Changeset 40227 in vbox for trunk/src/VBox/Runtime/r0drv/solaris

Timestamp:

Feb 23, 2012 11:15:37 AM (13 years ago)

Author:

vboxsync

Message:

VMM/VMMR0 SupDrv Solaris/MpNotification: Fix guru meditation/panics when host CPUs are dynamically offline'd/online'd. More flexibility if offline notifications don't fire on the desired CPU.

File:

• trunk/src/VBox/Runtime/r0drv/solaris/vbi/mpnotification-r0drv-solaris.c (modified) (1 diff)

trunk/src/VBox/Runtime/r0drv/solaris/vbi/mpnotification-r0drv-solaris.c

@@ -93 +93 @@
         rtMpNotificationSolarisOnCurrentCpu(&Args, NULL /* pvIgnored1 */, NULL /* pvIgnored2 */);
     else
-        vbi_execute_on_one(rtMpNotificationSolarisOnCurrentCpu, &Args, iCpu);
+    {
+        if (online)
+            vbi_execute_on_one(rtMpNotificationSolarisOnCurrentCpu, &Args, iCpu);
+        else
+        {
+            /*
+             * Since we don't absolutely need to do CPU bound code in any of the CPU offline
+             * notification hooks, run it on the current CPU. Scheduling a callback to execute
+             * on the CPU going offline at this point is too late and will not work reliably.
+             */
+            RTCpuSetDel(&g_rtMpSolarisCpuSet, iCpu);
+            rtMpNotificationDoCallbacks(RTMPEVENT_OFFLINE, iCpu);
+        }
+    }
 
     vbi_preempt_enable();