Changeset 4026 in vbox for trunk/src/VBox/Runtime/r3/posix

Timestamp:

Aug 3, 2007 5:29:19 PM (18 years ago)

Author:

vboxsync

Message:

Modified RTPathUserHome to return the value from the passwd file for user root to solve problems with the use of sudo

File:

• trunk/src/VBox/Runtime/r3/posix/path-posix.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/posix/path-posix.cpp

@@ -32 +32 @@
 #include <sys/time.h>
 #include <stdio.h>
+#include <sys/types.h>
+#include <pwd.h>
 #ifdef RT_OS_DARWIN
 # include <mach-o/dyld.h>
@@ -484 +486 @@
 RTDECL(int) RTPathUserHome(char *pszPath, unsigned cchPath)
 {
+    int rc;
+#ifndef RT_OS_L4
+    /*
+     * We make an exception for the root user and use the system call
+     * getpwuid_r to determine their initial home path instead of
+     * reading it from the $HOME variable.  This is because the $HOME
+     * variable does not get changed by sudo (and possibly su and others)
+     * which can cause root-owned files to appear in user's home folders.
+     */
+     uid_t uid = geteuid();
+     if (uid == 0)
+     {
+         /* The getpwuid_r function "allocates" any pointer memory it
+            needs from here.  In theory one should use the sysconf
+            function to find the appropriate size, but sysconf is
+            unreliable by design.  This should definitely be enough. */
+         char buffer[5120];
+         struct passwd sPasswd, *psPasswd;
+         rc = getpwuid_r(0, &sPasswd, buffer, sizeof(buffer), &psPasswd);
+         if (rc != 0)
+             return RTErrConvertFromErrno(rc);
+         /*
+          * Convert it to UTF-8 and copy it to the return buffer.
+          */
+         char *pszUtf8Path;
+         rc = rtPathFromNative(&pszUtf8Path, psPasswd->pw_dir);
+         if (RT_SUCCESS(rc))
+         {
+             size_t cchHome = strlen(pszUtf8Path);
+             if (cchHome < cchPath)
+                 memcpy(pszPath, pszUtf8Path, cchHome + 1);
+             else
+                 rc = VERR_BUFFER_OVERFLOW;
+             RTStrFree(pszUtf8Path);
+         }
+         LogFlow(("RTPathUserHome(%p:{%s}, %u): returns %Rrc\n", pszPath,
+                  RT_SUCCESS(rc) ? pszPath : "<failed>",  cchPath, rc));
+         return rc;
+     }
+#endif
     /*
      * Get HOME env. var it and validate it's existance.
      */
-    int rc;
     struct stat s;
     const char *pszHome = getenv("HOME");