Changeset 40278 in vbox for trunk/src/VBox/Additions/WINNT

Timestamp:

Feb 28, 2012 2:29:06 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

76505

Message:

VBOXSF: QueryVolumeInfo fixes.

File:

• trunk/src/VBox/Additions/WINNT/SharedFolders/driver/info.c (modified) (8 diffs)

trunk/src/VBox/Additions/WINNT/SharedFolders/driver/info.c

@@ -539 +539 @@
     ULONG cbInfoBuffer = RxContext->Info.LengthRemaining;
     ULONG cbToCopy = 0;
+    ULONG cbString = 0;
 
     Log(("VBOXSF: MrxQueryVolumeInfo: pInfoBuffer = %p, cbInfoBuffer = %d\n",
@@ -578 +579 @@
             pRootName++; /* Remove the leading backslash. */
 
-            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsVolumeInformation: Root name = %.*ls\n",
-                 cbRootName / sizeof(WCHAR), pRootName));
-
-            cbToCopy = sizeof(FILE_FS_VOLUME_INFORMATION);
-            cbToCopy += VBOX_VOLNAME_PREFIX_SIZE;
-            cbToCopy += cbRootName;
+            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsVolumeInformation: Root name = %.*ls, %d bytes\n",
+                 cbRootName / sizeof(WCHAR), pRootName, cbRootName));
+
+            cbToCopy = FIELD_OFFSET(FILE_FS_VOLUME_INFORMATION, VolumeLabel);
+
+            cbString  = VBOX_VOLNAME_PREFIX_SIZE;
+            cbString += cbRootName;
+            cbString += sizeof(WCHAR);
+
+            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsVolumeInformation: cbToCopy %d, cbString %d\n",
+                 cbToCopy, cbString));
 
             if (cbInfoBuffer < cbToCopy)
@@ -591 +597 @@
             }
 
-            RtlZeroMemory(pInfo, sizeof(FILE_FS_VOLUME_INFORMATION));
+            RtlZeroMemory(pInfo, cbToCopy);
 
             /* Query serial number. */
@@ -617 +623 @@
 
             pInfo->VolumeCreationTime.QuadPart = 0;
-            pInfo->VolumeLabelLength = VBOX_VOLNAME_PREFIX_SIZE + cbRootName;
             pInfo->SupportsObjects = FALSE;
 
-            RtlCopyMemory(&pInfo->VolumeLabel[0], VBOX_VOLNAME_PREFIX, VBOX_VOLNAME_PREFIX_SIZE);
-            RtlCopyMemory(&pInfo->VolumeLabel[VBOX_VOLNAME_PREFIX_SIZE / sizeof(WCHAR)], pRootName, cbRootName);
+            if (cbInfoBuffer >= cbToCopy + cbString)
+            {
+                RtlCopyMemory(&pInfo->VolumeLabel[0],
+                              VBOX_VOLNAME_PREFIX,
+                              VBOX_VOLNAME_PREFIX_SIZE);
+                RtlCopyMemory(&pInfo->VolumeLabel[VBOX_VOLNAME_PREFIX_SIZE / sizeof(WCHAR)],
+                              pRootName,
+                              cbRootName);
+                pInfo->VolumeLabel[cbString / sizeof(WCHAR) -  1] = 0;
+            }
+            else
+            {
+                cbString = cbInfoBuffer - cbToCopy;
+
+                RtlCopyMemory(&pInfo->VolumeLabel[0],
+                              VBOX_VOLNAME_PREFIX,
+                              RT_MIN(cbString, VBOX_VOLNAME_PREFIX_SIZE));
+                if (cbString > VBOX_VOLNAME_PREFIX_SIZE)
+                {
+                    RtlCopyMemory(&pInfo->VolumeLabel[VBOX_VOLNAME_PREFIX_SIZE / sizeof(WCHAR)],
+                                  pRootName,
+                                  cbString - VBOX_VOLNAME_PREFIX_SIZE);
+                }
+            }
+
+            pInfo->VolumeLabelLength = cbString;
+
+            cbToCopy += cbString;
+
             Log(("VBOXSF: MrxQueryVolumeInfo: FileFsVolumeInformation: VolumeLabelLength %d\n",
                  pInfo->VolumeLabelLength));
@@ -646 +678 @@
             pRootName++; /* Remove the leading backslash. */
 
-            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsLabelInformation: Root name = %.*ls\n",
-                 cbRootName / sizeof(WCHAR), pRootName));
-
-            cbToCopy = sizeof(FILE_FS_LABEL_INFORMATION);
-            cbToCopy += VBOX_VOLNAME_PREFIX_SIZE;
-            cbToCopy += cbRootName;
+            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsLabelInformation: Root name = %.*ls, %d bytes\n",
+                 cbRootName / sizeof(WCHAR), pRootName, cbRootName));
+
+            cbToCopy = FIELD_OFFSET(FILE_FS_LABEL_INFORMATION, VolumeLabel);
+
+            cbString  = VBOX_VOLNAME_PREFIX_SIZE;
+            cbString += cbRootName;
+            cbString += sizeof(WCHAR);
 
             if (cbInfoBuffer < cbToCopy)
@@ -659 +693 @@
             }
 
-            RtlZeroMemory(pInfo, sizeof(FILE_FS_LABEL_INFORMATION));
-
-            pInfo->VolumeLabelLength = VBOX_VOLNAME_PREFIX_SIZE + cbRootName;
-
-            RtlCopyMemory(&pInfo->VolumeLabel[0], VBOX_VOLNAME_PREFIX, VBOX_VOLNAME_PREFIX_SIZE);
-            RtlCopyMemory(&pInfo->VolumeLabel[VBOX_VOLNAME_PREFIX_SIZE / sizeof(WCHAR)], pRootName, cbRootName);
+            RtlZeroMemory(pInfo, cbToCopy);
+
+            if (cbInfoBuffer >= cbToCopy + cbString)
+            {
+                RtlCopyMemory(&pInfo->VolumeLabel[0],
+                              VBOX_VOLNAME_PREFIX,
+                              VBOX_VOLNAME_PREFIX_SIZE);
+                RtlCopyMemory(&pInfo->VolumeLabel[VBOX_VOLNAME_PREFIX_SIZE / sizeof(WCHAR)],
+                              pRootName,
+                              cbRootName);
+                pInfo->VolumeLabel[cbString / sizeof(WCHAR) -  1] = 0;
+            }
+            else
+            {
+                cbString = cbInfoBuffer - cbToCopy;
+
+                RtlCopyMemory(&pInfo->VolumeLabel[0],
+                              VBOX_VOLNAME_PREFIX,
+                              RT_MIN(cbString, VBOX_VOLNAME_PREFIX_SIZE));
+                if (cbString > VBOX_VOLNAME_PREFIX_SIZE)
+                {
+                    RtlCopyMemory(&pInfo->VolumeLabel[VBOX_VOLNAME_PREFIX_SIZE / sizeof(WCHAR)],
+                                  pRootName,
+                                  cbString - VBOX_VOLNAME_PREFIX_SIZE);
+                }
+            }
+
+            pInfo->VolumeLabelLength = cbString;
+
+            cbToCopy += cbString;
+
+            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsLabelInformation: VolumeLabelLength %d\n",
+                 pInfo->VolumeLabelLength));
 
             Status = STATUS_SUCCESS;
@@ -789 +850 @@
         case FileFsAttributeInformation:
         {
-            PFILE_FS_ATTRIBUTE_INFORMATION pAttribInfo = (PFILE_FS_ATTRIBUTE_INFORMATION)pInfoBuffer;
+            PFILE_FS_ATTRIBUTE_INFORMATION pInfo = (PFILE_FS_ATTRIBUTE_INFORMATION)pInfoBuffer;
 
             Log(("VBOXSF: MrxQueryVolumeInfo: FileFsAttributeInformation\n"));
 
-            cbToCopy = sizeof(FILE_FS_ATTRIBUTE_INFORMATION);
-            cbToCopy += sizeof(MRX_VBOX_FILESYS_NAME_U) - sizeof(WCHAR);
+            cbToCopy = FIELD_OFFSET(FILE_FS_ATTRIBUTE_INFORMATION, FileSystemName);
+
+            cbString = sizeof(MRX_VBOX_FILESYS_NAME_U);
 
             if (cbInfoBuffer < cbToCopy)
@@ -802 +864 @@
             }
 
-            pAttribInfo->FileSystemAttributes = 0; /** @todo set unicode, case sensitive etc? */
-            pAttribInfo->MaximumComponentNameLength = 255; /** @todo should query from the host */
-            pAttribInfo->FileSystemNameLength = sizeof(MRX_VBOX_FILESYS_NAME_U);
-            RtlCopyMemory(pAttribInfo->FileSystemName, MRX_VBOX_FILESYS_NAME_U, sizeof(MRX_VBOX_FILESYS_NAME_U));
+            pInfo->FileSystemAttributes = 0; /** @todo set unicode, case sensitive etc? */
+            pInfo->MaximumComponentNameLength = 255; /** @todo should query from the host */
+
+            if (cbInfoBuffer >= cbToCopy + cbString)
+            {
+                RtlCopyMemory(pInfo->FileSystemName,
+                              MRX_VBOX_FILESYS_NAME_U,
+                              sizeof(MRX_VBOX_FILESYS_NAME_U));
+            }
+            else
+            {
+                cbString = cbInfoBuffer - cbToCopy;
+
+                RtlCopyMemory(pInfo->FileSystemName,
+                              MRX_VBOX_FILESYS_NAME_U,
+                              RT_MIN(cbString, sizeof(MRX_VBOX_FILESYS_NAME_U)));
+            }
+
+            pInfo->FileSystemNameLength = cbString;
+
+            cbToCopy += cbString;
+
+            Log(("VBOXSF: MrxQueryVolumeInfo: FileFsAttributeInformation: FileSystemNameLength %d\n",
+                 pInfo->FileSystemNameLength));
 
             Status = STATUS_SUCCESS;