Changeset 40302 in vbox

Timestamp:

Feb 29, 2012 6:30:21 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

76550

Message:

Main/Console: fix deadlock in DVD change, many more such fixes to come

File:

• trunk/src/VBox/Main/src-client/ConsoleImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -4714 +4714 @@
 /**
  * Called by IInternalSessionControl::OnMediumChange().
- *
- * @note Locks this object for writing.
  */
 HRESULT Console::onMediumChange(IMediumAttachment *aMediumAttachment, BOOL aForce)
@@ -4723 +4721 @@
     AutoCaller autoCaller(this);
     AssertComRCReturnRC(autoCaller.rc());
-
-    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     HRESULT rc = S_OK;
@@ -4738 +4734 @@
     /* notify console callbacks on success */
     if (SUCCEEDED(rc))
-    {
-        alock.release(); /** @todo 101% safe? */
         fireMediumChangedEvent(mEventSource, aMediumAttachment);
-    }
 
     LogFlowThisFunc(("Leaving rc=%#x\n", rc));