Changeset 40359 in vbox for trunk/src/VBox/Additions/common/VBoxGuestLib

Timestamp:

Mar 5, 2012 3:10:10 PM (13 years ago)

Author:

vboxsync

Message:

VBoxGuest: disable page list HGCM transfers for Locked buffers to prevent crashes on Win guests

File:

• trunk/src/VBox/Additions/common/VBoxGuestLib/HGCMInternal.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxGuestLib/HGCMInternal.cpp

@@ -260 +260 @@
                 if (fIsUser)
                     return VERR_INVALID_PARAMETER;
-                if (!VBGLR0_CAN_USE_PHYS_PAGE_LIST())
+                /* always perform it as !VBGLR0_CAN_USE_PHYS_PAGE_LIST() since otherwise
+                 * we end up creating a RTR0MEMOBJ and doing page lock again, which leads to undefined behavior and possible BSOD on Win */
+                //if (!VBGLR0_CAN_USE_PHYS_PAGE_LIST())
                 {
                     cb = pSrcParm->u.Pointer.size;
@@ -537 +539 @@
             case VMMDevHGCMParmType_LinAddr_Locked_Out:
             case VMMDevHGCMParmType_LinAddr_Locked:
-                if (!VBGLR0_CAN_USE_PHYS_PAGE_LIST())
+                /* always perform it as !VBGLR0_CAN_USE_PHYS_PAGE_LIST() since otherwise
+                 * we end up creating a RTR0MEMOBJ and doing page lock again, which leads to undefined behavior and possible BSOD on Win */
+//                if (!VBGLR0_CAN_USE_PHYS_PAGE_LIST())
                 {
                     *pDstParm = *pSrcParm;
@@ -801 +805 @@
             case VMMDevHGCMParmType_LinAddr_Locked_Out:
             case VMMDevHGCMParmType_LinAddr_Locked:
-                if (!VBGLR0_CAN_USE_PHYS_PAGE_LIST())
+                /* always perform it as !VBGLR0_CAN_USE_PHYS_PAGE_LIST() since otherwise
+                 * we end up creating a RTR0MEMOBJ and doing page lock again, which leads to undefined behavior and possible BSOD on Win */
+//                if (!VBGLR0_CAN_USE_PHYS_PAGE_LIST())
                 {
                     pDstParm->u.Pointer.size = pSrcParm->u.Pointer.size;