Changeset 40403 in vbox for trunk

Timestamp:

Mar 8, 2012 4:14:42 PM (13 years ago)

Author:

vboxsync

Message:

GuestCtrl: Don't try too hard when searching for a new context ID.

File:

• trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp

@@ -122 +122 @@
     /* Create a new context ID and assign it. */
     uint32_t uNewContextID = 0;
+    uint32_t uTries = 0;
     for (;;)
     {
@@ -137 +138 @@
             break;
         }
+
+        if (++uTries == UINT32_MAX)
+            break; /* Don't try too hard. */
     }
 
@@ -191 +195 @@
 }
 
+/**
+ * Checks whether a callback with the given context ID
+ * exists or not.
+ * Does not do locking!
+ *
+ * @return  bool                True, if callback exists, false if not.
+ * @param   uContextID          Context ID to check.
+ */
 bool Guest::callbackExists(uint32_t uContextID)
 {
     AssertReturn(uContextID, false);
-
-    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     CallbackMapIter it = mCallbackMap.find(uContextID);