Changeset 40806 in vbox for trunk/src/VBox/Devices/Bus

Timestamp:

Apr 6, 2012 9:05:19 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

77321

Message:

RTSpinlock: Redid the interface, eliminating NoInts and Tmp. Whether a spinlock is interrupt safe or not is now defined at creation time, preventing stupid bugs arrising from calling the wrong acquire and/or release methods somewhere. The saved flags are stored in the spinlock strucutre, eliminating the annoying Tmp variable. Needs testing on each platform before fixing the build burn.

File:

• trunk/src/VBox/Devices/Bus/SrvPciRawR0.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Bus/SrvPciRawR0.cpp

@@ -95 +95 @@
 static DECLCALLBACK(bool) pcirawr0Isr(void* pContext, int32_t iHostIrq)
 {
-    RTSPINLOCKTMP aTmp;
     PPCIRAWDEV    pThis = (PPCIRAWDEV)pContext;
 
@@ -114 +113 @@
 #endif
 
-    RTSpinlockAcquireNoInts(pThis->hSpinlock, &aTmp);
+    RTSpinlockAcquire(pThis->hSpinlock);
     pThis->iPendingIrq = iHostIrq;
-    RTSpinlockReleaseNoInts(pThis->hSpinlock, &aTmp);
+    RTSpinlockReleaseNoInts(pThis->hSpinlock);
 
     /**
@@ -575 +574 @@
         if (RT_SUCCESS(rc))
         {
-            rc = RTSpinlockCreate(&pNew->hSpinlock);
+            rc = RTSpinlockCreate(&pNew->hSpinlock, RTSPINLOCK_FLAGS_INTERRUPT_SAFE, "PciRaw");
             AssertRC(rc);
             rc = RTSemEventCreate(&pNew->hIrqEvent);
@@ -862 +861 @@
 {
     int            rc = VINF_SUCCESS;
-    RTSPINLOCKTMP  aTmp;
     bool           fTerminate = false;
     int32_t        iPendingIrq = 0;
@@ -870 +868 @@
     GET_PORT(TargetDevice);
 
-    RTSpinlockAcquireNoInts(pDev->hSpinlock, &aTmp);
+    RTSpinlockAcquire(pDev->hSpinlock);
     iPendingIrq = pDev->iPendingIrq;
     pDev->iPendingIrq = 0;
     fTerminate = pDev->fTerminate;
-    RTSpinlockReleaseNoInts(pDev->hSpinlock, &aTmp);
+    RTSpinlockReleaseNoInts(pDev->hSpinlock);
 
     /* Block until new IRQs arrives */
@@ -887 +885 @@
                 if (!ASMAtomicReadBool(&pDev->fTerminate))
                 {
-                    RTSpinlockAcquireNoInts(pDev->hSpinlock, &aTmp);
+                    RTSpinlockAcquire(pDev->hSpinlock);
                     iPendingIrq = pDev->iPendingIrq;
                     pDev->iPendingIrq = 0;
-                    RTSpinlockReleaseNoInts(pDev->hSpinlock, &aTmp);
+                    RTSpinlockReleaseNoInts(pDev->hSpinlock);
                 }
                 else