Changeset 40806 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Apr 6, 2012 9:05:19 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

77321

Message:

RTSpinlock: Redid the interface, eliminating NoInts and Tmp. Whether a spinlock is interrupt safe or not is now defined at creation time, preventing stupid bugs arrising from calling the wrong acquire and/or release methods somewhere. The saved flags are stored in the spinlock strucutre, eliminating the annoying Tmp variable. Needs testing on each platform before fixing the build burn.

File:

• trunk/src/VBox/VMM/VMMR3/PDMBlkCache.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR3/PDMBlkCache.cpp

@@ -657 +657 @@
     /* The list is moved to a new header to reduce locking overhead. */
     RTLISTANCHOR ListDirtyNotCommitted;
-    RTSPINLOCKTMP Tmp;
 
     RTListInit(&ListDirtyNotCommitted);
-    RTSpinlockAcquire(pBlkCache->LockList, &Tmp);
+    RTSpinlockAcquire(pBlkCache->LockList);
     RTListMove(&ListDirtyNotCommitted, &pBlkCache->ListDirtyNotCommitted);
-    RTSpinlockRelease(pBlkCache->LockList, &Tmp);
+    RTSpinlockRelease(pBlkCache->LockList);
 
     if (!RTListIsEmpty(&ListDirtyNotCommitted))
@@ -755 +754 @@
         pEntry->fFlags |= PDMBLKCACHE_ENTRY_IS_DIRTY;
 
-        RTSPINLOCKTMP Tmp;
-        RTSpinlockAcquire(pBlkCache->LockList, &Tmp);
+        RTSpinlockAcquire(pBlkCache->LockList);
         RTListAppend(&pBlkCache->ListDirtyNotCommitted, &pEntry->NodeNotCommitted);
-        RTSpinlockRelease(pBlkCache->LockList, &Tmp);
+        RTSpinlockRelease(pBlkCache->LockList);
 
         uint32_t cbDirty = ASMAtomicAddU32(&pCache->cbDirty, pEntry->cbData);
@@ -1220 +1218 @@
             RTListInit(&pBlkCache->ListDirtyNotCommitted);
 
-            rc = RTSpinlockCreate(&pBlkCache->LockList);
+            rc = RTSpinlockCreate(&pBlkCache->LockList, RTSPINLOCK_FLAGS_INTERRUPT_UNSAFE, "pdmR3BlkCacheRetain");
             if (RT_SUCCESS(rc))
             {