Changeset 40806 in vbox for trunk/src/VBox/VMM/VMMRZ

Timestamp:

Apr 6, 2012 9:05:19 PM (13 years ago)

Author:

vboxsync

Message:

RTSpinlock: Redid the interface, eliminating NoInts and Tmp. Whether a spinlock is interrupt safe or not is now defined at creation time, preventing stupid bugs arrising from calling the wrong acquire and/or release methods somewhere. The saved flags are stored in the spinlock strucutre, eliminating the annoying Tmp variable. Needs testing on each platform before fixing the build burn.

File:

• trunk/src/VBox/VMM/VMMRZ/PGMRZDynMap.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMRZ/PGMRZDynMap.cpp

@@ -88 +88 @@
  */
 # define PGMRZDYNMAP_SPINLOCK_ACQUIRE(pThis) \
-    RTSPINLOCKTMP   MySpinlockTmp = RTSPINLOCKTMP_INITIALIZER; \
-    RTSpinlockAcquire((pThis)->hSpinlock, &MySpinlockTmp)
+    RTSpinlockAcquire((pThis)->hSpinlock)
+
 /**
  * Releases the spinlock.
  */
 # define PGMRZDYNMAP_SPINLOCK_RELEASE(pThis) \
-    RTSpinlockRelease((pThis)->hSpinlock, &MySpinlockTmp)
+    RTSpinlockRelease((pThis)->hSpinlock)
 
 /**
@@ -100 +100 @@
  */
 # define PGMRZDYNMAP_SPINLOCK_REACQUIRE(pThis) \
-    RTSpinlockAcquire((pThis)->hSpinlock, &MySpinlockTmp)
+    RTSpinlockAcquire((pThis)->hSpinlock)
 #else
 # define PGMRZDYNMAP_SPINLOCK_ACQUIRE(pThis)   do { } while (0)
@@ -408 +408 @@
         if (RT_SUCCESS(rc))
         {
-            rc = RTSpinlockCreate(&pThis->hSpinlock);
+            rc = RTSpinlockCreate(&pThis->hSpinlock, RTSPINLOCK_FLAGS_INTERRUPT_UNSAFE, "PGMR0DynMap");
             if (RT_SUCCESS(rc))
             {