Changeset 41019 in vbox for trunk/src/VBox/Devices

Timestamp:

Apr 22, 2012 6:05:26 PM (13 years ago)

Author:

vboxsync

Message:

Devices/ATA: Introduce option to suppress overwriting inquiry data for ATAPI drives in passthrough mode

Location:

trunk/src/VBox/Devices

Files:

• Storage/DevATA.cpp (modified) (3 diffs)
• testcase/tstDeviceStructSizeRC.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -252 +252 @@
     /** Enable passing through commands directly to the ATAPI drive. */
     bool            fATAPIPassthrough;
+    /** Flag whether to overwrite inquiry data in passthrough mode. */
+    bool            fOverwriteInquiry;
     /** Number of errors we've reported to the release log.
      * This is to prevent flooding caused by something going horribly wrong.
@@ -2280 +2282 @@
                 s->cbTotalTransfer = cbTransfer;
 
-            if (s->aATAPICmd[0] == SCSI_INQUIRY)
+            if (   s->aATAPICmd[0] == SCSI_INQUIRY
+                && s->fOverwriteInquiry)
             {
                 /* Make sure that the real drive cannot be identified.
@@ -7599 +7602 @@
                                         N_("PIIX3 configuration error: failed to read \"ATAPIRevision\" as string"));
                         }
+
+                        rc = CFGMR3QueryBoolDef(pCfgNode, "OverwriteInquiry", &pIf->fOverwriteInquiry, true);
+                        if (RT_FAILURE(rc))
+                            return PDMDEV_SET_ERROR(pDevIns, rc,
+                                        N_("PIIX3 configuration error: failed to read \"OverwriteInquiry\" as boolean"));
                     }
                 }

trunk/src/VBox/Devices/testcase/tstDeviceStructSizeRC.cpp

@@ -783 +783 @@
     GEN_CHECK_OFF(ATADevState, StatBytesWritten);
     GEN_CHECK_OFF(ATADevState, StatFlushes);
+    GEN_CHECK_OFF(ATADevState, fNonRotational);
     GEN_CHECK_OFF(ATADevState, fATAPIPassthrough);
+    GEN_CHECK_OFF(ATADevState, fOverwriteInquiry);
     GEN_CHECK_OFF(ATADevState, cErrors);
     GEN_CHECK_OFF(ATADevState, pDrvBase);