Changeset 41184 in vbox for trunk/src/VBox/Frontends/VBoxBFE

Timestamp:

May 7, 2012 1:28:04 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

77810

Message:

Main+Frontends: removed unused and confusing VirtualBoxErrorInfo implementation, and cleaned up lots of misleading comments and other leftovers about the earlier ErrorInfo mess

Location:

trunk/src/VBox/Frontends/VBoxBFE

Files:

• NetworkAdapterImpl.cpp (modified) (1 diff)
• VirtualBoxBase.h (modified) (8 diffs)

trunk/src/VBox/Frontends/VBoxBFE/NetworkAdapterImpl.cpp

@@ -187 +187 @@
         AssertMsgFailed(("Invalid file descriptor: %ld.\n", tapFileDescriptor));
 
-        //    setError  VirtualBoxSupportErrorInfoImplBase which
-        //       is a parent class of NetworAdapter in the COM flavored version
-        //    return setError (E_INVALIDARG,
-        //        tr ("Invalid file descriptor: %ld"), tapFileDescriptor);
-
-        return S_OK;
-
+        return setError (E_INVALIDARG,
+                tr ("Invalid file descriptor: %ld"), tapFileDescriptor);
     }
 

trunk/src/VBox/Frontends/VBoxBFE/VirtualBoxBase.h

@@ -81 +81 @@
 
 /**
- *  A special version of the Assert macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  Assert macro wrapper.
  *
  *  In the debug build, this macro is equivalent to Assert.
- *  In the release build, this macro uses |setError (E_FAIL, ...)| to set the
- *  error info from the asserted expression.
- *
- *  @see VirtualBoxSupportErrorInfoImpl::setError
+ *  In the release build, this is a no-op.
  *
  *  @param   expr    Expression which should be true.
@@ -100 +96 @@
 
 /**
- *  A special version of the AssertMsg macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  AssertMsg macro wrapper.
+ *
+ *  In the debug build, this macro is equivalent to AssertMsg.
+ *  In the release build, this is a no-op.
  *
  *  See ComAssert for more info.
@@ -116 +114 @@
 
 /**
- *  A special version of the AssertRC macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  AssertRC macro wrapper.
+ *
+ *  In the debug build, this macro is equivalent to AssertRC.
+ *  In the release build, this is a no-op.
  *
  *  See ComAssert for more info.
@@ -130 +130 @@
 
 /**
- *  A special version of the AssertMsgRC macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  AssertMsgRC macro wrapper.
+ *
+ *  In the debug build, this macro is equivalent to AssertMsgRC.
+ *  In the release build, this is a no-op.
  *
  *  See ComAssert for more info.
@@ -146 +148 @@
 
 /**
- *  A special version of the AssertFailed macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  AssertFailed macro wrapper.
+ *
+ *  In the debug build, this macro is equivalent to AssertFailed.
+ *  In the release build, this is a no-op.
  *
  *  See ComAssert for more info.
@@ -159 +163 @@
 
 /**
- *  A special version of the AssertMsgFailed macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  AssertMsgFailed macro wrapper.
+ *
+ *  In the debug build, this macro is equivalent to AssertMsgFailed.
+ *  In the release build, this is a no-op.
  *
  *  See ComAssert for more info.
@@ -174 +180 @@
 
 /**
- *  A special version of the AssertComRC macro to be used within VirtualBoxBase
- *  subclasses that also inherit the VirtualBoxSupportErrorInfoImpl template.
+ *  AssertComRC macro wrapper.
+ *
+ *  In the debug build, this macro is equivalent to AssertComRC.
+ *  In the release build, this is a no-op.
  *
  *  See ComAssert for more info.
@@ -246 +254 @@
  *  This macro <b>must</b> be used at the beginning of all interface methods
  *  (right after entering the class lock) in classes derived from both
- *  VirtualBoxBase and VirtualBoxSupportErrorInfoImpl.
+ *  VirtualBoxBase.
  */
 #define CHECK_READY() \