Changeset 41528 in vbox for trunk/src/VBox/Main/src-server/darwin

Timestamp:

May 31, 2012 4:48:33 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

78291

Message:

Main/HostUSBDevice(all platforms)+USBProxyService: redo USB locking, fixes major regression, added lots of assertions to catch locking flaws early, whitespace cleanup
Main/Machine: small USB locking fix to be consistent with the remaining code
Main/Host+glue/AutoLock: replace USB list lock by host lock, small numbering cleanup
Main/Console: redo USB locking, do less in USB callbacks/EMT (addresses long standing todo items), eliminate unsafe iterator parameters

File:

• trunk/src/VBox/Main/src-server/darwin/USBProxyServiceDarwin.cpp (modified) (16 diffs)

trunk/src/VBox/Main/src-server/darwin/USBProxyServiceDarwin.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2006-2010 Oracle Corporation
+ * Copyright (C) 2005-2012 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -39 +39 @@
  * Initialize data members.
  */
-USBProxyServiceDarwin::USBProxyServiceDarwin (Host *aHost)
-    : USBProxyService (aHost), mServiceRunLoopRef (NULL), mNotifyOpaque (NULL), mWaitABitNextTime (false), mUSBLibInitialized (false)
+USBProxyServiceDarwin::USBProxyServiceDarwin(Host *aHost)
+    : USBProxyService(aHost), mServiceRunLoopRef(NULL), mNotifyOpaque(NULL), mWaitABitNextTime(false), mUSBLibInitialized(false)
 {
     LogFlowThisFunc(("aHost=%p\n", aHost));
@@ -101 +101 @@
 
 #ifdef VBOX_WITH_NEW_USB_CODE_ON_DARWIN
-void *USBProxyServiceDarwin::insertFilter (PCUSBFILTER aFilter)
-{
-    return USBLibAddFilter (aFilter);
-}
-
-
-void USBProxyServiceDarwin::removeFilter (void *aId)
-{
-    USBLibRemoveFilter (aId);
+void *USBProxyServiceDarwin::insertFilter(PCUSBFILTER aFilter)
+{
+    return USBLibAddFilter(aFilter);
+}
+
+
+void USBProxyServiceDarwin::removeFilter(void *aId)
+{
+    USBLibRemoveFilter(aId);
 }
 #endif /* VBOX_WITH_NEW_USB_CODE_ON_DARWIN */
@@ -120 +120 @@
      */
     AssertReturn(aDevice, VERR_GENERAL_FAILURE);
+    AssertReturn(!aDevice->isWriteLockOnCurrentThread(), VERR_GENERAL_FAILURE);
+
+    AutoReadLock devLock(aDevice COMMA_LOCKVAL_SRC_POS);
     LogFlowThisFunc(("aDevice=%s\n", aDevice->getName().c_str()));
-    AssertReturn(aDevice->isWriteLockOnCurrentThread(), VERR_GENERAL_FAILURE);
+
     Assert(aDevice->getUnistate() == kHostUSBDeviceState_Capturing);
 
@@ -129 +132 @@
      */
     ASMAtomicWriteBool(&mFakeAsync, true);
+    devLock.release();
     interruptWait();
     return VINF_SUCCESS;
@@ -161 +165 @@
 void USBProxyServiceDarwin::captureDeviceCompleted(HostUSBDevice *aDevice, bool aSuccess)
 {
+    AssertReturnVoid(aDevice->isWriteLockOnCurrentThread());
 #ifdef VBOX_WITH_NEW_USB_CODE_ON_DARWIN
     /*
@@ -179 +184 @@
      */
     AssertReturn(aDevice, VERR_GENERAL_FAILURE);
+    AssertReturn(!aDevice->isWriteLockOnCurrentThread(), VERR_GENERAL_FAILURE);
+
+    AutoReadLock devLock(aDevice COMMA_LOCKVAL_SRC_POS);
     LogFlowThisFunc(("aDevice=%s\n", aDevice->getName().c_str()));
-    AssertReturn(aDevice->isWriteLockOnCurrentThread(), VERR_GENERAL_FAILURE);
+
     Assert(aDevice->getUnistate() == kHostUSBDeviceState_ReleasingToHost);
 
@@ -188 +196 @@
      */
     ASMAtomicWriteBool(&mFakeAsync, true);
+    devLock.release();
     interruptWait();
     return VINF_SUCCESS;
@@ -222 +231 @@
 void USBProxyServiceDarwin::releaseDeviceCompleted(HostUSBDevice *aDevice, bool aSuccess)
 {
+    AssertReturnVoid(aDevice->isWriteLockOnCurrentThread());
 #ifdef VBOX_WITH_NEW_USB_CODE_ON_DARWIN
     /*
@@ -234 +244 @@
 
 
+/** @todo unused */
 void USBProxyServiceDarwin::detachingDevice(HostUSBDevice *aDevice)
 {
 #ifndef VBOX_WITH_NEW_USB_CODE_ON_DARWIN
-    aDevice->setLogicalReconnect (HostUSBDevice::kDetachingPendingDetach);
+    aDevice->setLogicalReconnect(HostUSBDevice::kDetachingPendingDetach);
 #else
     NOREF(aDevice);
@@ -246 +257 @@
 bool USBProxyServiceDarwin::updateDeviceState(HostUSBDevice *aDevice, PUSBDEVICE aUSBDevice, bool *aRunFilters, SessionMachine **aIgnoreMachine)
 {
+    AssertReturn(aDevice, false);
+    AssertReturn(!aDevice->isWriteLockOnCurrentThread(), false);
 #ifndef VBOX_WITH_NEW_USB_CODE_ON_DARWIN
     /* We're faking async state stuff. */
@@ -264 +277 @@
 #endif
 
-    SInt32 rc = CFRunLoopRunInMode(CFSTR (VBOX_IOKIT_MODE_STRING),
+    SInt32 rc = CFRunLoopRunInMode(CFSTR(VBOX_IOKIT_MODE_STRING),
                                    mWaitABitNextTime && aMillies >= 1000
                                    ? 1.0 /* seconds */
@@ -277 +290 @@
 
 
-int USBProxyServiceDarwin::interruptWait (void)
+int USBProxyServiceDarwin::interruptWait(void)
 {
     if (mServiceRunLoopRef)
-        CFRunLoopStop (mServiceRunLoopRef);
+        CFRunLoopStop(mServiceRunLoopRef);
     return 0;
 }
 
 
-PUSBDEVICE USBProxyServiceDarwin::getDevices (void)
+PUSBDEVICE USBProxyServiceDarwin::getDevices(void)
 {
     /* call iokit.cpp */
@@ -292 +305 @@
 
 
-void USBProxyServiceDarwin::serviceThreadInit (void)
+void USBProxyServiceDarwin::serviceThreadInit(void)
 {
     mServiceRunLoopRef = CFRunLoopGetCurrent();
@@ -299 +312 @@
 
 
-void USBProxyServiceDarwin::serviceThreadTerm (void)
-{
-    DarwinUnsubscribeUSBNotifications (mNotifyOpaque);
+void USBProxyServiceDarwin::serviceThreadTerm(void)
+{
+    DarwinUnsubscribeUSBNotifications(mNotifyOpaque);
     mServiceRunLoopRef = NULL;
 }
@@ -311 +324 @@
  * @param   pCur    The USB device to free.
  */
-void DarwinFreeUSBDeviceFromIOKit (PUSBDEVICE pCur)
-{
-    USBProxyService::freeDevice (pCur);
-}
-
+void DarwinFreeUSBDeviceFromIOKit(PUSBDEVICE pCur)
+{
+    USBProxyService::freeDevice(pCur);
+}
+