Changeset 41658 in vbox for trunk/src/VBox/Disassembler/testcase

Timestamp:

Jun 11, 2012 10:21:44 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

78464

Message:

DIS,VMM,REM,IPRT: Disassembler API adjustments.

Location:

trunk/src/VBox/Disassembler/testcase

Files:

• Makefile.kmk (modified) (2 diffs)
• tstDisasm-2.cpp (modified) (10 diffs)

trunk/src/VBox/Disassembler/testcase/Makefile.kmk

@@ -60 +60 @@
 #       $(PATH_STAGE_BIN)/testcase/tstDisasm-2$(SUFF_EXEC)
 endif
+VBOX_DISAS_TESTS_BINARIES_NOT_16BIT := \
+        tstBinFnstsw-1.bin
+VBOX_DISAS_TESTS_BINARIES_NOT_32BIT :=
+VBOX_DISAS_TESTS_BINARIES_NOT_64BIT :=
 
 
@@ -195 +199 @@
 
 ## @todo 64-bit is problematic because of bugs like POP RDI ending up as POP EDI (incorrect default opmode).
-#$(foreach bits, 32 16 64, $(foreach binary, $(VBOX_DISAS_TESTS_BINARIES), $(evalvalctx def_vbox_disas_binary)))
-$(foreach bits, 32 16, $(foreach binary, $(VBOX_DISAS_TESTS_BINARIES), $(evalvalctx def_vbox_disas_binary)))
+#$(foreach bits, 64, $(foreach binary, $(VBOX_DISAS_TESTS_BINARIES), $(evalvalctx def_vbox_disas_binary)))
+$(foreach bits, 32 16, $(foreach binary, $(filter-out $(VBOX_DISAS_TESTS_BINARIES_NOT_$(bits)BIT), $(VBOX_DISAS_TESTS_BINARIES)) \
+        , $(evalvalctx def_vbox_disas_binary)))
 
 

trunk/src/VBox/Disassembler/testcase/tstDisasm-2.cpp

@@ -171 +171 @@
  *       however the current doesn't do this and is just complicated...
  */
-static DECLCALLBACK(int) MyDisasInstrRead(RTUINTPTR uSrcAddr, uint8_t *pbDst, uint32_t cbRead, void *pvDisCpu)
-{
-    PMYDISSTATE pState = (PMYDISSTATE)pvDisCpu;
+static DECLCALLBACK(int) MyDisasInstrRead(PDISCPUSTATE pDisState, uint8_t *pbDst, RTUINTPTR uSrcAddr, uint32_t cbToRead)
+{
+    PMYDISSTATE pState = (PMYDISSTATE)pDisState;
     if (RT_LIKELY(   pState->uNextAddr == uSrcAddr
-                  && pState->cbLeft >= cbRead))
+                  && pState->cbLeft >= cbToRead))
     {
         /*
          * Straight forward reading.
          */
-        if (cbRead == 1)
+        if (cbToRead == 1)
         {
             pState->cbLeft--;
@@ -188 +188 @@
         else
         {
-            memcpy(pbDst, pState->pbNext, cbRead);
-            pState->pbNext += cbRead;
-            pState->cbLeft -= cbRead;
-            pState->uNextAddr += cbRead;
+            memcpy(pbDst, pState->pbNext, cbToRead);
+            pState->pbNext += cbToRead;
+            pState->cbLeft -= cbToRead;
+            pState->uNextAddr += cbToRead;
         }
     }
@@ -211 +211 @@
                 pState->cbLeft = 0;
 
-                memset(pbDst, 0xcc, cbRead);
+                memset(pbDst, 0xcc, cbToRead);
                 pState->rc = VERR_EOF;
                 return VERR_EOF;
@@ -227 +227 @@
 
             /* do the reading. */
-            if (pState->cbLeft >= cbRead)
-            {
-                memcpy(pbDst, pState->pbNext, cbRead);
-                pState->cbLeft -= cbRead;
-                pState->pbNext += cbRead;
-                pState->uNextAddr += cbRead;
+            if (pState->cbLeft >= cbToRead)
+            {
+                memcpy(pbDst, pState->pbNext, cbToRead);
+                pState->cbLeft -= cbToRead;
+                pState->pbNext += cbToRead;
+                pState->uNextAddr += cbToRead;
             }
             else
@@ -240 +240 @@
                     memcpy(pbDst, pState->pbNext, pState->cbLeft);
                     pbDst += pState->cbLeft;
-                    cbRead -= (uint32_t)pState->cbLeft;
+                    cbToRead -= (uint32_t)pState->cbLeft;
                     pState->pbNext += pState->cbLeft;
                     pState->uNextAddr += pState->cbLeft;
                     pState->cbLeft = 0;
                 }
-                memset(pbDst, 0xcc, cbRead);
+                memset(pbDst, 0xcc, cbToRead);
                 pState->rc = VERR_EOF;
                 return VERR_EOF;
@@ -253 +253 @@
         {
             RTStrmPrintf(g_pStdErr, "Reading before current instruction!\n");
-            memset(pbDst, 0x90, cbRead);
+            memset(pbDst, 0x90, cbToRead);
             pState->rc = VERR_INTERNAL_ERROR;
             return VERR_INTERNAL_ERROR;
@@ -286 +286 @@
      */
     MYDISSTATE State;
-    State.Cpu.mode = enmCpuMode;
-    State.Cpu.pfnReadBytes = MyDisasInstrRead;
     State.uAddress = uAddress;
     State.pbInstr = pbFile;
@@ -331 +329 @@
         State.pbNext = State.pbInstr;
 
-        int rc = DISInstr(&State.Cpu, State.uAddress, 0, &State.cbInstr, State.szLine);
+
+        int rc = DISInstrWithReader(State.uAddress, enmCpuMode, MyDisasInstrRead, &State,
+                                    &State.Cpu, &State.cbInstr, State.szLine);
         if (    RT_SUCCESS(rc)
             ||  (   (   rc == VERR_DIS_INVALID_OPCODE
@@ -345 +345 @@
             if (State.fUndefOp && State.enmUndefOp == kUndefOp_DefineByte)
             {
+                if (!State.cbInstr)
+                {
+                    State.Cpu.abInstr[0] = 0;
+                    State.Cpu.pfnReadBytes(&State.Cpu, &State.Cpu.abInstr[0], State.uAddress, 1);
+                    State.cbInstr = 1;
+                }
                 RTPrintf("    db");
-                if (!State.cbInstr)
-                    State.cbInstr = 1;
                 for (unsigned off = 0; off < State.cbInstr; off++)
-                {
-                    uint8_t b;
-                    State.Cpu.pfnReadBytes(State.uAddress + off, &b, 1, &State.Cpu);
-                    RTPrintf(off ? ", %03xh" : " %03xh", b);
-                }
+                    RTPrintf(off ? ", %03xh" : " %03xh", State.Cpu.abInstr[off]);
                 RTPrintf("    ; %s\n", State.szLine);
             }
@@ -376 +376 @@
                     RTPrintf("    db");
                     for (unsigned off = 0; off < State.cbInstr; off++)
-                    {
-                        uint8_t b;
-                        State.Cpu.pfnReadBytes(State.uAddress + off, &b, 1, &State.Cpu);
-                        RTPrintf(off ? ", %03xh" : " %03xh", b);
-                    }
+                        RTPrintf(off ? ", %03xh" : " %03xh", State.Cpu.abInstr[off]);
                     RTPrintf(" ; ");
                 }