Changeset 41730 in vbox

Timestamp:

Jun 14, 2012 11:28:16 PM (13 years ago)

Author:

vboxsync

Message:

DIS: Some nits.

Location:

trunk

Files:

• include/VBox/dis.h (modified) (3 diffs)
• src/VBox/Disassembler/DisasmFormatYasm.cpp (modified) (3 diffs)
• src/VBox/VMM/VMMAll/IOMAll.cpp (modified) (2 diffs)
• src/VBox/VMM/include/IOMInternal.h (modified) (1 diff)

trunk/include/VBox/dis.h

@@ -487 +487 @@
 typedef DISOPPARAM *PDISOPPARAM;
 /** Pointer to opcode parameter. */
-typedef const DISOPPARAM *PCOP_PARAMETER;
-
-
+typedef const DISOPPARAM *PCDISOPPARAM;
+
+
+/**
+ * Opcode descriptor.
+ */
+typedef struct DISOPCODE
+{
+#ifndef DIS_CORE_ONLY
+    const char  *pszOpcode;
+#endif
+    uint8_t     idxParse1;
+    uint8_t     idxParse2;
+    uint8_t     idxParse3;
+    uint8_t     uUnused;
+    uint16_t    opcode;
+    uint16_t    param1;
+    uint16_t    param2;
+    uint16_t    param3;
+    uint32_t    optype;
+} DISOPCODE;
 /** Pointer to const opcode. */
 typedef const struct DISOPCODE *PCDISOPCODE;
+
 
 /**
@@ -511 +530 @@
  * @remark no DECLCALLBACK() here because it's considered to be internal (really, I'm too lazy to update all the functions). */
 typedef unsigned FNDISPARSE(RTUINTPTR pu8CodeBlock, PCDISOPCODE pOp, PDISOPPARAM pParam, PDISCPUSTATE pCpu);
+/** Pointer to a disassembler parser function. */
 typedef FNDISPARSE *PFNDISPARSE;
+/** Pointer to a const disassembler parser function pointer. */
 typedef PFNDISPARSE const *PCPFNDISPARSE;
 
+/**
+ * The diassembler state and result.
+ */
 typedef struct DISCPUSTATE
 {
@@ -614 +638 @@
 
 
-/**
- * Opcode descriptor.
- */
-typedef struct DISOPCODE
-{
-#ifndef DIS_CORE_ONLY
-    const char  *pszOpcode;
-#endif
-    uint8_t     idxParse1;
-    uint8_t     idxParse2;
-    uint8_t     idxParse3;
-    uint8_t     uUnused;
-    uint16_t    opcode;
-    uint16_t    param1;
-    uint16_t    param2;
-    uint16_t    param3;
-    uint32_t    optype;
-} DISOPCODE;
-
 
 DISDECL(int) DISInstrToStr(void const *pvInstr, DISCPUMODE enmCpuMode,

trunk/src/VBox/Disassembler/DisasmFormatYasm.cpp

@@ -91 +91 @@
  * @param   pcchReg     Where to store the length of the name.
  */
-static const char *disasmFormatYasmBaseReg(PCDISCPUSTATE pCpu, PCOP_PARAMETER pParam, size_t *pcchReg)
+static const char *disasmFormatYasmBaseReg(PCDISCPUSTATE pCpu, PCDISOPPARAM pParam, size_t *pcchReg)
 {
     switch (pParam->fUse & (  DISUSE_REG_GEN8 | DISUSE_REG_GEN16 | DISUSE_REG_GEN32 | DISUSE_REG_GEN64
@@ -202 +202 @@
  * @param   pcchReg     Where to store the length of the name.
  */
-static const char *disasmFormatYasmIndexReg(PCDISCPUSTATE pCpu, PCOP_PARAMETER pParam, size_t *pcchReg)
+static const char *disasmFormatYasmIndexReg(PCDISCPUSTATE pCpu, PCDISOPPARAM pParam, size_t *pcchReg)
 {
     switch (pCpu->addrmode)
@@ -554 +554 @@
          * Formatting context and associated macros.
          */
-        PCOP_PARAMETER pParam = &pCpu->param1;
+        PCDISOPPARAM pParam = &pCpu->param1;
         int iParam = 1;
 

trunk/src/VBox/VMM/VMMAll/IOMAll.cpp

@@ -65 +65 @@
  * @param   pcbSize             Where to store the size of data (1, 2, 4, 8).
  */
-bool iomGetRegImmData(PDISCPUSTATE pCpu, PCOP_PARAMETER pParam, PCPUMCTXCORE pRegFrame, uint64_t *pu64Data, unsigned *pcbSize)
+bool iomGetRegImmData(PDISCPUSTATE pCpu, PCDISOPPARAM pParam, PCPUMCTXCORE pRegFrame, uint64_t *pu64Data, unsigned *pcbSize)
 {
     NOREF(pCpu);
@@ -159 +159 @@
  * @param   u64Data             8/16/32/64 bit data to store.
  */
-bool iomSaveDataToReg(PDISCPUSTATE pCpu, PCOP_PARAMETER pParam, PCPUMCTXCORE pRegFrame, uint64_t u64Data)
+bool iomSaveDataToReg(PDISCPUSTATE pCpu, PCDISOPPARAM pParam, PCPUMCTXCORE pRegFrame, uint64_t u64Data)
 {
     NOREF(pCpu);

trunk/src/VBox/VMM/include/IOMInternal.h

@@ -431 +431 @@
 
 /* Disassembly helpers used in IOMAll.cpp & IOMAllMMIO.cpp */
-bool    iomGetRegImmData(PDISCPUSTATE pCpu, PCOP_PARAMETER pParam, PCPUMCTXCORE pRegFrame, uint64_t *pu64Data, unsigned *pcbSize);
-bool    iomSaveDataToReg(PDISCPUSTATE pCpu, PCOP_PARAMETER pParam, PCPUMCTXCORE pRegFrame, uint64_t u32Data);
+bool    iomGetRegImmData(PDISCPUSTATE pCpu, PCDISOPPARAM pParam, PCPUMCTXCORE pRegFrame, uint64_t *pu64Data, unsigned *pcbSize);
+bool    iomSaveDataToReg(PDISCPUSTATE pCpu, PCDISOPPARAM pParam, PCPUMCTXCORE pRegFrame, uint64_t u32Data);
 
 RT_C_DECLS_END